<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17062">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/GSUP_Types: add dest name to some messages<br><br>Prepare for upcoming D-GSM test, that lets OsmoHLR act as proxy. It<br>forwards the messages based on the destination name, so the testsuite<br>must set it correctly.<br><br>Related: OS#4380<br>Change-Id: I7623b7a7c7a18ba18a38d0834979d18ab0fbb961<br>---<br>M library/GSUP_Types.ttcn<br>1 file changed, 9 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn</span><br><span>index 0f36d4d..fa912c1 100644</span><br><span>--- a/library/GSUP_Types.ttcn</span><br><span>+++ b/library/GSUP_Types.ttcn</span><br><span>@@ -502,8 +502,9 @@</span><br><span> template GSUP_PDU tr_GSUP_UL_REQ(template hexstring imsi) :=</span><br><span>  tr_GSUP_IMSI(OSMO_GSUP_MSGT_UPDATE_LOCATION_REQUEST, imsi);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-template (value) GSUP_PDU ts_GSUP_UL_RES(hexstring imsi) :=</span><br><span style="color: hsl(0, 100%, 40%);">-      ts_GSUP(OSMO_GSUP_MSGT_UPDATE_LOCATION_RESULT, { valueof(ts_GSUP_IE_IMSI(imsi)) });</span><br><span style="color: hsl(120, 100%, 40%);">+template (value) GSUP_PDU ts_GSUP_UL_RES(hexstring imsi, octetstring destination_name := ''O) :=</span><br><span style="color: hsl(120, 100%, 40%);">+ ts_GSUP(OSMO_GSUP_MSGT_UPDATE_LOCATION_RESULT, { valueof(ts_GSUP_IE_IMSI(imsi)),</span><br><span style="color: hsl(120, 100%, 40%);">+                      valueof(ts_GSUP_IE_Destination_Name(destination_name))});</span><br><span> </span><br><span> template GSUP_PDU tr_GSUP_UL_RES(template hexstring imsi) :=</span><br><span>        tr_GSUP_IMSI(OSMO_GSUP_MSGT_UPDATE_LOCATION_RESULT, imsi);</span><br><span>@@ -516,17 +517,19 @@</span><br><span>   tr_GSUP(OSMO_GSUP_MSGT_UPDATE_LOCATION_ERROR, {</span><br><span>                      tr_GSUP_IE_IMSI(imsi), tr_GSUP_IE_Cause(cause) });</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-template (value) GSUP_PDU ts_GSUP_ISD_REQ(hexstring imsi, hexstring msisdn) :=</span><br><span style="color: hsl(120, 100%, 40%);">+template (value) GSUP_PDU ts_GSUP_ISD_REQ(hexstring imsi, hexstring msisdn, octetstring destination_name := ''O) :=</span><br><span>    ts_GSUP(OSMO_GSUP_MSGT_INSERT_DATA_REQUEST, {</span><br><span style="color: hsl(0, 100%, 40%);">-                   valueof(ts_GSUP_IE_IMSI(imsi)), valueof(ts_GSUP_IE_MSISDN(msisdn)) });</span><br><span style="color: hsl(120, 100%, 40%);">+                        valueof(ts_GSUP_IE_IMSI(imsi)), valueof(ts_GSUP_IE_MSISDN(msisdn)),</span><br><span style="color: hsl(120, 100%, 40%);">+                   valueof(ts_GSUP_IE_Destination_Name(destination_name))});</span><br><span> </span><br><span> template GSUP_PDU tr_GSUP_ISD_REQ(template hexstring imsi, template hexstring msisdn := ?) :=</span><br><span>       tr_GSUP(OSMO_GSUP_MSGT_INSERT_DATA_REQUEST, {</span><br><span>                        tr_GSUP_IE_IMSI(imsi), *, tr_GSUP_IE_MSISDN(msisdn), * });</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-template (value) GSUP_PDU ts_GSUP_ISD_RES(hexstring imsi) :=</span><br><span style="color: hsl(120, 100%, 40%);">+template (value) GSUP_PDU ts_GSUP_ISD_RES(hexstring imsi, octetstring destination_name := ''O) :=</span><br><span>        ts_GSUP(OSMO_GSUP_MSGT_INSERT_DATA_RESULT, {</span><br><span style="color: hsl(0, 100%, 40%);">-                    valueof(ts_GSUP_IE_IMSI(imsi)) });</span><br><span style="color: hsl(120, 100%, 40%);">+                    valueof(ts_GSUP_IE_IMSI(imsi)),</span><br><span style="color: hsl(120, 100%, 40%);">+                       valueof(ts_GSUP_IE_Destination_Name(destination_name))});</span><br><span> </span><br><span> template GSUP_PDU tr_GSUP_ISD_RES(template hexstring imsi) :=</span><br><span>       tr_GSUP_IMSI(OSMO_GSUP_MSGT_INSERT_DATA_RESULT, imsi);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17062">change 17062</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17062"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7623b7a7c7a18ba18a38d0834979d18ab0fbb961 </div>
<div style="display:none"> Gerrit-Change-Number: 17062 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>