<p>Patch set 28:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16206">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16206/28/include/osmocom/gsupclient/gsup_client.h">File include/osmocom/gsupclient/gsup_client.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16206/28/include/osmocom/gsupclient/gsup_client.h@62">Patch Set #28, Line 62:</a> <code style="font-family:monospace,monospace">osmo_gsup_client_config</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">That's a nice idea to finally group all parameters into a structure!</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16206/28/include/osmocom/gsupclient/gsup_client.h@69">Patch Set #28, Line 69:</a> <code style="font-family:monospace,monospace">tcp_port</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Just an idea: what if somebody wants to use a different transport layer, e.g. SCTP? We could make the new function more flexible by adding an enumerated type (osmo_gsup_transport_proto?) and a union to this structure:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  ...<br>  enum osmo_gsup_transport_proto transport_proto;<br>  const char *ip_addr;<br>  union {<br>    struct tcp_ipa {<br>      struct ipaccess_unit *ipa_dev;<br>      unsigned int port;<br>    }<br>  } u;<br>  ...</pre><p style="white-space: pre-wrap; word-wrap: break-word;">For now osmo_gsup_client_create3() would return -ENOTSUPP for transport_proto != TCP_IPA.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16206">change 16206</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/16206"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6f181e42b678465bc9945f192559dc57d2083c6d </div>
<div style="display:none"> Gerrit-Change-Number: 16206 </div>
<div style="display:none"> Gerrit-PatchSet: 28 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 30 Jan 2020 09:51:16 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>