<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17006">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm_timer: fix comparison of constant LONG_MAX with an integer<br><br>It does not make sense since INT_MAX is always less than LONG_MAX.<br>Found by Clang [-Wtautological-constant-out-of-range-compare].<br><br>Change-Id: I9934e05aa050bf93b3c795376f5dca3a848a7e11<br>---<br>M src/gsm_timer.cpp<br>1 file changed, 7 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm_timer.cpp b/src/gsm_timer.cpp</span><br><span>index f7901d4..cefe520 100644</span><br><span>--- a/src/gsm_timer.cpp</span><br><span>+++ b/src/gsm_timer.cpp</span><br><span>@@ -144,17 +144,14 @@</span><br><span> </span><br><span> static void update_nearest(int *cand, int *current)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-      if (*cand != LONG_MAX) {</span><br><span style="color: hsl(0, 100%, 40%);">-                if (*cand > *current)</span><br><span style="color: hsl(0, 100%, 40%);">-                        nearest = *cand - *current;</span><br><span style="color: hsl(0, 100%, 40%);">-             else {</span><br><span style="color: hsl(0, 100%, 40%);">-                  /* loop again inmediately */</span><br><span style="color: hsl(0, 100%, 40%);">-                    nearest = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-            }</span><br><span style="color: hsl(0, 100%, 40%);">-               nearest_p = &nearest;</span><br><span style="color: hsl(0, 100%, 40%);">-       } else {</span><br><span style="color: hsl(0, 100%, 40%);">-                nearest_p = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+     if (*cand > *current)</span><br><span style="color: hsl(120, 100%, 40%);">+              nearest = *cand - *current;</span><br><span style="color: hsl(120, 100%, 40%);">+   else {</span><br><span style="color: hsl(120, 100%, 40%);">+                /* loop again inmediately */</span><br><span style="color: hsl(120, 100%, 40%);">+          nearest = 0;</span><br><span>         }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   nearest_p = &nearest;</span><br><span> }</span><br><span> </span><br><span> /*</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17006">change 17006</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/17006"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9934e05aa050bf93b3c795376f5dca3a848a7e11 </div>
<div style="display:none"> Gerrit-Change-Number: 17006 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>