<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/17040">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-msc: use stderr to print error messages, not stdout<br><br>Change-Id: I702dd054d2e881b526f701ca482ec0f64ba8da28<br>---<br>M src/osmo-msc/msc_main.c<br>1 file changed, 12 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/40/17040/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c</span><br><span>index dc6b684..cf1e504 100644</span><br><span>--- a/src/osmo-msc/msc_main.c</span><br><span>+++ b/src/osmo-msc/msc_main.c</span><br><span>@@ -26,6 +26,7 @@</span><br><span> </span><br><span> #include <stdbool.h></span><br><span> #include <unistd.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <stdio.h></span><br><span> #include <time.h></span><br><span> #include <errno.h></span><br><span> #include <signal.h></span><br><span>@@ -609,20 +610,20 @@</span><br><span> msc_network->ctrl = ctrl_interface_setup_dynip(msc_network, ctrl_vty_get_bind_addr(),</span><br><span> OSMO_CTRL_PORT_MSC, NULL);</span><br><span> if (!msc_network->ctrl) {</span><br><span style="color: hsl(0, 100%, 40%);">- printf("Failed to initialize control interface. Exiting.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "Failed to initialize control interface. Exiting.\n");</span><br><span> return -1;</span><br><span> }</span><br><span> </span><br><span> #if 0</span><br><span> TODO: we probably want some of the _net_ ctrl commands from bsc_base_ctrl_cmds_install().</span><br><span> if (bsc_base_ctrl_cmds_install() != 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- printf("Failed to initialize the BSC control commands.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "Failed to initialize the BSC control commands.\n");</span><br><span> return -1;</span><br><span> }</span><br><span> #endif</span><br><span> </span><br><span> if (msc_ctrl_cmds_install(msc_network) != 0) {</span><br><span style="color: hsl(0, 100%, 40%);">- printf("Failed to initialize the MSC control commands.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "Failed to initialize the MSC control commands.\n");</span><br><span> return -1;</span><br><span> }</span><br><span> </span><br><span>@@ -632,8 +633,8 @@</span><br><span> * should try to use the nanoseconds part of the current time. */</span><br><span> </span><br><span> if (db_init(msc_cmdline_config.database_name)) {</span><br><span style="color: hsl(0, 100%, 40%);">- printf("DB: Failed to init database: %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">- msc_cmdline_config.database_name);</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "DB: Failed to init database: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ msc_cmdline_config.database_name);</span><br><span> return 4;</span><br><span> }</span><br><span> </span><br><span>@@ -650,7 +651,7 @@</span><br><span> }</span><br><span> </span><br><span> if (db_prepare()) {</span><br><span style="color: hsl(0, 100%, 40%);">- printf("DB: Failed to prepare database.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "DB: Failed to prepare database.\n");</span><br><span> return 5;</span><br><span> }</span><br><span> </span><br><span>@@ -669,17 +670,17 @@</span><br><span> msc_network, &msc_network->mgw.conf);</span><br><span> </span><br><span> if (mgcp_client_connect(msc_network->mgw.client)) {</span><br><span style="color: hsl(0, 100%, 40%);">- printf("MGCPGW connect failed\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "MGCPGW connect failed\n");</span><br><span> return 7;</span><br><span> }</span><br><span> </span><br><span> if (ss7_setup(tall_msc_ctx, &sccp_a, &sccp_iu)) {</span><br><span style="color: hsl(0, 100%, 40%);">- printf("Setting up SCCP client failed.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "Setting up SCCP client failed.\n");</span><br><span> return 8;</span><br><span> }</span><br><span> </span><br><span> if (sgs_server_open(g_sgs)) {</span><br><span style="color: hsl(0, 100%, 40%);">- printf("Starting SGs server failed\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "Starting SGs server failed\n");</span><br><span> return 9;</span><br><span> }</span><br><span> </span><br><span>@@ -687,7 +688,7 @@</span><br><span> "OsmoMSC-A", &msc_ran_infra[OSMO_RAT_GERAN_A],</span><br><span> msc_network);</span><br><span> if (!msc_network->a.sri) {</span><br><span style="color: hsl(0, 100%, 40%);">- printf("Setting up A receiver failed\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "Setting up A receiver failed\n");</span><br><span> return 10;</span><br><span> }</span><br><span> LOGP(DMSC, LOGL_NOTICE, "A-interface: SCCP user %s, cs7-instance %u (%s)\n",</span><br><span>@@ -702,7 +703,7 @@</span><br><span> "OsmoMSC-IuCS", &msc_ran_infra[OSMO_RAT_UTRAN_IU],</span><br><span> msc_network);</span><br><span> if (!msc_network->iu.sri) {</span><br><span style="color: hsl(0, 100%, 40%);">- printf("Setting up IuCS receiver failed\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "Setting up IuCS receiver failed\n");</span><br><span> return 11;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/17040">change 17040</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/17040"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I702dd054d2e881b526f701ca482ec0f64ba8da28 </div>
<div style="display:none"> Gerrit-Change-Number: 17040 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>