<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17000">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">csn1: Fix an infinite loop in CSN.1 dissector when having more than 255 padding bits<br><br>Port of wireshark.git 8b5aa913711b32b1e1bc707919d2a98c1875d443.<br><br>Ported-by: Pau Espin Pedrol <pespin@sysmocom.de><br>Change-Id: I7f6aecc2c0f300c1a77cd683652969d3f1aa5794<br>---<br>M src/csn1.cpp<br>M src/csn1.h<br>2 files changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/csn1.cpp b/src/csn1.cpp</span><br><span>index 493d471..21bb976 100644</span><br><span>--- a/src/csn1.cpp</span><br><span>+++ b/src/csn1.cpp</span><br><span>@@ -1150,7 +1150,7 @@</span><br><span>         {</span><br><span>           while (remaining_bits_len > 0)</span><br><span>           {</span><br><span style="color: hsl(0, 100%, 40%);">-            guint8 bits_to_handle = remaining_bits_len%8;</span><br><span style="color: hsl(120, 100%, 40%);">+            guint bits_to_handle = remaining_bits_len%8;</span><br><span>             if (bits_to_handle > 0)</span><br><span>             {</span><br><span>         LOGPC(DCSN1, LOGL_NOTICE, "%" PRIu64 "|", bitvec_read_field(vector, &readIndex, bits_to_handle));</span><br><span>diff --git a/src/csn1.h b/src/csn1.h</span><br><span>index c5ee919..0da529c 100644</span><br><span>--- a/src/csn1.h</span><br><span>+++ b/src/csn1.h</span><br><span>@@ -56,6 +56,7 @@</span><br><span> typedef signed int gint32;</span><br><span> typedef signed short gint16;</span><br><span> typedef int gint;</span><br><span style="color: hsl(120, 100%, 40%);">+typedef unsigned int guint;</span><br><span> typedef gint gboolean;</span><br><span> typedef unsigned char guint8;</span><br><span> typedef unsigned short guint16;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17000">change 17000</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/17000"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7f6aecc2c0f300c1a77cd683652969d3f1aa5794 </div>
<div style="display:none"> Gerrit-Change-Number: 17000 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>