<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/16989">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests/rlcmac: Memzero decoded struct<br><br>Otherwise final output is undefined.<br><br>Change-Id: I9b501b8a99473b4d79279f8a3a9854e0b2eb3284<br>---<br>M tests/rlcmac/RLCMACTest.cpp<br>1 file changed, 9 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp</span><br><span>index acfe56a..5ed8c0f 100644</span><br><span>--- a/tests/rlcmac/RLCMACTest.cpp</span><br><span>+++ b/tests/rlcmac/RLCMACTest.cpp</span><br><span>@@ -119,12 +119,13 @@</span><br><span> cout << hex << (unsigned)*(vector->data + i);</span><br><span> }</span><br><span> cout << endl;</span><br><span style="color: hsl(0, 100%, 40%);">- RlcMacDownlink_t * data = (RlcMacDownlink_t *)malloc(sizeof(RlcMacDownlink_t));</span><br><span style="color: hsl(120, 100%, 40%);">+ RlcMacDownlink_t data;</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(&data, 0, sizeof(data));</span><br><span> cout << "=========Start DECODE===========" << endl;</span><br><span style="color: hsl(0, 100%, 40%);">- decode_gsm_rlcmac_downlink(vector, data);</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_gsm_rlcmac_downlink(vector, &data);</span><br><span> cout << "+++++++++Finish DECODE++++++++++" << endl;</span><br><span> cout << "=========Start ENCODE=============" << endl;</span><br><span style="color: hsl(0, 100%, 40%);">- encode_gsm_rlcmac_downlink(resultVector, data);</span><br><span style="color: hsl(120, 100%, 40%);">+ encode_gsm_rlcmac_downlink(resultVector, &data);</span><br><span> cout << "+++++++++Finish ENCODE+++++++++++" << endl;</span><br><span> cout << "vector1 = ";</span><br><span> for (int i = 0; i < 23; i++)</span><br><span>@@ -148,7 +149,6 @@</span><br><span> }</span><br><span> bitvec_unhex(resultVector, DUMMY_VEC);</span><br><span> bitvec_free(vector);</span><br><span style="color: hsl(0, 100%, 40%);">- free(data);</span><br><span> }</span><br><span> </span><br><span> bitvec_free(resultVector);</span><br><span>@@ -183,12 +183,13 @@</span><br><span> cout << hex << (unsigned)*(vector->data + i);</span><br><span> }</span><br><span> cout << endl;</span><br><span style="color: hsl(0, 100%, 40%);">- RlcMacUplink_t * data = (RlcMacUplink_t *)malloc(sizeof(RlcMacUplink_t));</span><br><span style="color: hsl(120, 100%, 40%);">+ RlcMacUplink_t data;</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(&data, 0, sizeof(data));</span><br><span> cout << "=========Start DECODE===========" << endl;</span><br><span style="color: hsl(0, 100%, 40%);">- decode_gsm_rlcmac_uplink(vector, data);</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_gsm_rlcmac_uplink(vector, &data);</span><br><span> cout << "+++++++++Finish DECODE++++++++++" << endl;</span><br><span> cout << "=========Start ENCODE=============" << endl;</span><br><span style="color: hsl(0, 100%, 40%);">- encode_gsm_rlcmac_uplink(resultVector, data);</span><br><span style="color: hsl(120, 100%, 40%);">+ encode_gsm_rlcmac_uplink(resultVector, &data);</span><br><span> cout << "+++++++++Finish ENCODE+++++++++++" << endl;</span><br><span> cout << "vector1 = ";</span><br><span> for (int i = 0; i < 23; i++)</span><br><span>@@ -212,7 +213,6 @@</span><br><span> }</span><br><span> bitvec_unhex(resultVector, DUMMY_VEC);</span><br><span> bitvec_free(vector);</span><br><span style="color: hsl(0, 100%, 40%);">- free(data);</span><br><span> }</span><br><span> </span><br><span> bitvec_free(resultVector);</span><br><span>@@ -227,6 +227,7 @@</span><br><span> </span><br><span> bitvec_unhex(vector, "40200bffd161003e0e519ffffffb800000000000000000");</span><br><span> RlcMacUplink_t data;</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(&data, 0, sizeof(data));</span><br><span> </span><br><span> EGPRS_AckNack_Desc_t *urbb =</span><br><span> &data.u.Egprs_Packet_Downlink_Ack_Nack.EGPRS_AckNack.Desc;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/16989">change 16989</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/16989"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9b501b8a99473b4d79279f8a3a9854e0b2eb3284 </div>
<div style="display:none"> Gerrit-Change-Number: 16989 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>