<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/17011">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vlr: remove unused parameter 'log_level' of auth_fsm_start()<br><br>We unconditionally use logging level of the parent FSM anyway.<br>All callers of auth_fsm_start() always pass fi->log_level.<br><br>Change-Id: If2fdf2564eb56d3d94ec3800bdcb0aabcad4e48d<br>---<br>M src/libvlr/vlr_access_req_fsm.c<br>M src/libvlr/vlr_auth_fsm.c<br>M src/libvlr/vlr_auth_fsm.h<br>M src/libvlr/vlr_lu_fsm.c<br>4 files changed, 2 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/11/17011/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libvlr/vlr_access_req_fsm.c b/src/libvlr/vlr_access_req_fsm.c</span><br><span>index 7684d02..73f8955 100644</span><br><span>--- a/src/libvlr/vlr_access_req_fsm.c</span><br><span>+++ b/src/libvlr/vlr_access_req_fsm.c</span><br><span>@@ -338,7 +338,7 @@</span><br><span>       if (is_auth_required(par)) {</span><br><span>                 osmo_fsm_inst_state_chg(fi, PR_ARQ_S_WAIT_AUTH,</span><br><span>                                      0, 0);</span><br><span style="color: hsl(0, 100%, 40%);">-          vsub->auth_fsm = auth_fsm_start(vsub, fi->log_level, fi,</span><br><span style="color: hsl(120, 100%, 40%);">+                vsub->auth_fsm = auth_fsm_start(vsub, fi,</span><br><span>                                                 PR_ARQ_E_AUTH_RES,</span><br><span>                                           par->is_r99,</span><br><span>                                              par->is_utran);</span><br><span>diff --git a/src/libvlr/vlr_auth_fsm.c b/src/libvlr/vlr_auth_fsm.c</span><br><span>index dcdf584..1cacbce 100644</span><br><span>--- a/src/libvlr/vlr_auth_fsm.c</span><br><span>+++ b/src/libvlr/vlr_auth_fsm.c</span><br><span>@@ -596,7 +596,6 @@</span><br><span> </span><br><span> /* MSC->VLR: Start Procedure Authenticate_VLR (TS 23.012 Ch. 4.1.2.2) */</span><br><span> struct osmo_fsm_inst *auth_fsm_start(struct vlr_subscr *vsub,</span><br><span style="color: hsl(0, 100%, 40%);">-                                uint32_t log_level,</span><br><span>                                  struct osmo_fsm_inst *parent,</span><br><span>                                uint32_t parent_term_event,</span><br><span>                                  bool is_r99,</span><br><span>diff --git a/src/libvlr/vlr_auth_fsm.h b/src/libvlr/vlr_auth_fsm.h</span><br><span>index 1f2cb49..4be889f 100644</span><br><span>--- a/src/libvlr/vlr_auth_fsm.h</span><br><span>+++ b/src/libvlr/vlr_auth_fsm.h</span><br><span>@@ -30,7 +30,6 @@</span><br><span> struct osmo_fsm vlr_auth_fsm;</span><br><span> </span><br><span> struct osmo_fsm_inst *auth_fsm_start(struct vlr_subscr *vsub,</span><br><span style="color: hsl(0, 100%, 40%);">-                                 uint32_t log_level,</span><br><span>                                  struct osmo_fsm_inst *parent,</span><br><span>                                uint32_t parent_term_event,</span><br><span>                                  bool is_r99,</span><br><span>diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c</span><br><span>index e4d40f0..d5425e7 100644</span><br><span>--- a/src/libvlr/vlr_lu_fsm.c</span><br><span>+++ b/src/libvlr/vlr_lu_fsm.c</span><br><span>@@ -906,7 +906,7 @@</span><br><span>             /* Authenticate_VLR */</span><br><span>               osmo_fsm_inst_state_chg(fi, VLR_ULA_S_WAIT_AUTH,</span><br><span>                                     LU_TIMEOUT_LONG, 0);</span><br><span style="color: hsl(0, 100%, 40%);">-            vsub->auth_fsm = auth_fsm_start(lfp->vsub, fi->log_level,</span><br><span style="color: hsl(120, 100%, 40%);">+            vsub->auth_fsm = auth_fsm_start(lfp->vsub,</span><br><span>                                             fi, VLR_ULA_E_AUTH_RES,</span><br><span>                                              lfp->is_r99,</span><br><span>                                              lfp->is_utran);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/17011">change 17011</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/17011"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If2fdf2564eb56d3d94ec3800bdcb0aabcad4e48d </div>
<div style="display:none"> Gerrit-Change-Number: 17011 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>