<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17008">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">encoding: fix log_alert_exit(): do not treat error as format string<br><br>This is rather a cosmetic change aimed to make ASAN / Coverity happy.<br>In general, we never pass any input from an untrusted source.<br><br>Change-Id: I26d654da4c3bf5fd86a298c3027fd9820c932308<br>---<br>M src/encoding.cpp<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/08/17008/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/encoding.cpp b/src/encoding.cpp</span><br><span>index 8c3aaed..23b35bd 100644</span><br><span>--- a/src/encoding.cpp</span><br><span>+++ b/src/encoding.cpp</span><br><span>@@ -432,7 +432,7 @@</span><br><span> </span><br><span> static inline void log_alert_exit(const char * error)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-     LOGP(DRLCMACUL, LOGL_ERROR, error);</span><br><span style="color: hsl(120, 100%, 40%);">+   LOGP(DRLCMACUL, LOGL_ERROR, "%s", error);</span><br><span>  pcu_tx_txt_ind(PCU_OML_ALERT, error);</span><br><span>        exit(1);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/17008">change 17008</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/17008"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I26d654da4c3bf5fd86a298c3027fd9820c932308 </div>
<div style="display:none"> Gerrit-Change-Number: 17008 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>