<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/16989">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests/rlcmac: Memzero decoded struct<br><br>Otherwise final output is undefined.<br><br>Change-Id: I9b501b8a99473b4d79279f8a3a9854e0b2eb3284<br>---<br>M tests/rlcmac/RLCMACTest.cpp<br>M tests/rlcmac/RLCMACTest.ok<br>2 files changed, 9 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/89/16989/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp</span><br><span>index 0721fd1..039cdf8 100644</span><br><span>--- a/tests/rlcmac/RLCMACTest.cpp</span><br><span>+++ b/tests/rlcmac/RLCMACTest.cpp</span><br><span>@@ -114,12 +114,13 @@</span><br><span> cout << "vector1 = " << testData[i] << endl;</span><br><span> bitvec *vector = bitvec_alloc(23, test_ctx);</span><br><span> bitvec_unhex(vector, testData[i].c_str());</span><br><span style="color: hsl(0, 100%, 40%);">- RlcMacDownlink_t * data = (RlcMacDownlink_t *)malloc(sizeof(RlcMacDownlink_t));</span><br><span style="color: hsl(120, 100%, 40%);">+ RlcMacDownlink_t data;</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(&data, 0, sizeof(data));</span><br><span> cout << "=========Start DECODE===========" << endl;</span><br><span style="color: hsl(0, 100%, 40%);">- decode_gsm_rlcmac_downlink(vector, data);</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_gsm_rlcmac_downlink(vector, &data);</span><br><span> cout << "+++++++++Finish DECODE++++++++++" << endl;</span><br><span> cout << "=========Start ENCODE=============" << endl;</span><br><span style="color: hsl(0, 100%, 40%);">- encode_gsm_rlcmac_downlink(resultVector, data);</span><br><span style="color: hsl(120, 100%, 40%);">+ encode_gsm_rlcmac_downlink(resultVector, &data);</span><br><span> cout << "+++++++++Finish ENCODE+++++++++++" << endl;</span><br><span> cout << "vector1 = " << osmo_hexdump(vector->data, 23) << endl;</span><br><span> cout << "vector2 = " << osmo_hexdump(resultVector->data, 23) << endl;</span><br><span>@@ -129,7 +130,6 @@</span><br><span> cout << "vector1 == vector2 : FALSE" << endl;</span><br><span> bitvec_unhex(resultVector, DUMMY_VEC);</span><br><span> bitvec_free(vector);</span><br><span style="color: hsl(0, 100%, 40%);">- free(data);</span><br><span> }</span><br><span> </span><br><span> bitvec_free(resultVector);</span><br><span>@@ -159,12 +159,13 @@</span><br><span> cout << "vector1 = " << testData[i] << endl;</span><br><span> bitvec *vector = bitvec_alloc(23, test_ctx);</span><br><span> bitvec_unhex(vector, testData[i].c_str());</span><br><span style="color: hsl(0, 100%, 40%);">- RlcMacUplink_t * data = (RlcMacUplink_t *)malloc(sizeof(RlcMacUplink_t));</span><br><span style="color: hsl(120, 100%, 40%);">+ RlcMacUplink_t data;</span><br><span style="color: hsl(120, 100%, 40%);">+ memset(&data, 0, sizeof(data));</span><br><span> cout << "=========Start DECODE===========" << endl;</span><br><span style="color: hsl(0, 100%, 40%);">- decode_gsm_rlcmac_uplink(vector, data);</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_gsm_rlcmac_uplink(vector, &data);</span><br><span> cout << "+++++++++Finish DECODE++++++++++" << endl;</span><br><span> cout << "=========Start ENCODE=============" << endl;</span><br><span style="color: hsl(0, 100%, 40%);">- encode_gsm_rlcmac_uplink(resultVector, data);</span><br><span style="color: hsl(120, 100%, 40%);">+ encode_gsm_rlcmac_uplink(resultVector, &data);</span><br><span> cout << "+++++++++Finish ENCODE+++++++++++" << endl;</span><br><span> cout << "vector1 = " << osmo_hexdump(vector->data, 23) << endl;</span><br><span> cout << "vector2 = " << osmo_hexdump(resultVector->data, 23) << endl;</span><br><span>@@ -174,7 +175,6 @@</span><br><span> cout << "vector1 == vector2 : FALSE" << endl;</span><br><span> bitvec_unhex(resultVector, DUMMY_VEC);</span><br><span> bitvec_free(vector);</span><br><span style="color: hsl(0, 100%, 40%);">- free(data);</span><br><span> }</span><br><span> </span><br><span> bitvec_free(resultVector);</span><br><span>diff --git a/tests/rlcmac/RLCMACTest.ok b/tests/rlcmac/RLCMACTest.ok</span><br><span>index 64aafc3..2af4d90 100644</span><br><span>--- a/tests/rlcmac/RLCMACTest.ok</span><br><span>+++ b/tests/rlcmac/RLCMACTest.ok</span><br><span>@@ -62,7 +62,7 @@</span><br><span> =========Start ENCODE=============</span><br><span> +++++++++Finish ENCODE+++++++++++</span><br><span> vector1 = 49 13 e0 08 50 88 40 13 a8 04 8b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b </span><br><span style="color: hsl(0, 100%, 40%);">-vector2 = 49 13 43 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b </span><br><span style="color: hsl(120, 100%, 40%);">+vector2 = 49 13 01 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b </span><br><span> vector1 == vector2 : FALSE</span><br><span> vector1 = 412430007fffffffffffffffefd19c7ba12b2b2b2b2b2b</span><br><span> =========Start DECODE===========</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/16989">change 16989</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/16989"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9b501b8a99473b4d79279f8a3a9854e0b2eb3284 </div>
<div style="display:none"> Gerrit-Change-Number: 16989 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>