<p>herlesupreeth has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/16977">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Added checks for SPN<br><br>Change-Id: I35fab9a85efda2b83f221a460d31c7d41db582b0<br>---<br>M pySim-prog.py<br>M pySim/cards.py<br>2 files changed, 10 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/77/16977/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim-prog.py b/pySim-prog.py</span><br><span>index 709086d..b19c24b 100755</span><br><span>--- a/pySim-prog.py</span><br><span>+++ b/pySim-prog.py</span><br><span>@@ -276,6 +276,12 @@</span><br><span>   # Digitize MCC/MNC (5 or 6 digits)</span><br><span>   plmn_digits = _mcc_mnc_digits(mcc, mnc)</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   name = None</span><br><span style="color: hsl(120, 100%, 40%);">+   if opts.name is not None:</span><br><span style="color: hsl(120, 100%, 40%);">+             if len(opts.name) > 16:</span><br><span style="color: hsl(120, 100%, 40%);">+                    raise ValueError('Service Provider Name must max 16 characters!');</span><br><span style="color: hsl(120, 100%, 40%);">+            name = opts.name</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   msisdn = None</span><br><span>        if opts.msisdn is not None:</span><br><span>          if len(opts.msisdn) > 10*2:</span><br><span>@@ -424,7 +430,7 @@</span><br><span> </span><br><span>     # Return that</span><br><span>        return {</span><br><span style="color: hsl(0, 100%, 40%);">-                'name'  : opts.name,</span><br><span style="color: hsl(120, 100%, 40%);">+          'name'  : name,</span><br><span>              'iccid' : iccid,</span><br><span>             'mcc'   : mcc,</span><br><span>               'mnc'   : mnc,</span><br><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index 59e4dff..bec33f7 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -613,8 +613,9 @@</span><br><span>                    data, sw = self._scc.update_binary('00F7', content)</span><br><span> </span><br><span>              # set Service Provider Name</span><br><span style="color: hsl(0, 100%, 40%);">-             content = enc_spn(p['name'], True, True)</span><br><span style="color: hsl(0, 100%, 40%);">-                data, sw = self._scc.update_binary('6F46', rpad(content, 32))</span><br><span style="color: hsl(120, 100%, 40%);">+         if p.get('name') is not None:</span><br><span style="color: hsl(120, 100%, 40%);">+                 content = enc_spn(p['name'], True, True)</span><br><span style="color: hsl(120, 100%, 40%);">+                      data, sw = self._scc.update_binary('6F46', rpad(content, 32))</span><br><span> </span><br><span>            # write EF.IMSI</span><br><span>              data, sw = self._scc.update_binary('6f07', enc_imsi(p['imsi']))</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/16977">change 16977</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/16977"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I35fab9a85efda2b83f221a460d31c7d41db582b0 </div>
<div style="display:none"> Gerrit-Change-Number: 16977 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>