<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/16961">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sccp: Disarm inactivity timer upon T(iar) active->disconn_pend<br><br>All other code paths moving to state DISCONN_PEND seem to stop them, and<br>anyway that state doesn't permit event SCOC_E_T_IAS_EXP:<br><br>DLSCCP DEBUG SCCP-SCOC(0){ACTIVE}: Received Event T(iar)_expired (sccp_scoc.c:346)<br>...<br>DLSCCP DEBUG SCCP-SCOC(0){ACTIVE}: state_chg to DISCONN_PEND (sccp_scoc.c:1095)<br>...<br>DLSCCP DEBUG SCCP-SCOC(0){DISCONN_PEND}: Received Event T(ias)_expired (sccp_scoc.c:339)<br>DLSCCP ERROR SCCP-SCOC(0){DISCONN_PEND}: Event T(ias)_expired not permitted (sccp_scoc.c:339)<br><br>Change-Id: Ieb02dedba312ab76890e943934ce6a1e2fe61f74<br>---<br>M src/sccp_scoc.c<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/61/16961/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c</span><br><span>index d2fb8d1..015850e 100644</span><br><span>--- a/src/sccp_scoc.c</span><br><span>+++ b/src/sccp_scoc.c</span><br><span>@@ -1081,6 +1081,8 @@</span><br><span>            osmo_fsm_inst_state_chg(fi, S_IDLE, 0, 0);</span><br><span>           break;</span><br><span>       case SCOC_E_T_IAR_EXP:</span><br><span style="color: hsl(120, 100%, 40%);">+                /* stop inact timers */</span><br><span style="color: hsl(120, 100%, 40%);">+               conn_stop_inact_timers(conn);</span><br><span>                xua = xua_msg_alloc();</span><br><span>               xua_msg_add_u32(xua, SUA_IEI_CAUSE,</span><br><span>                          SUA_CAUSE_T_RELEASE | SCCP_RELEASE_CAUSE_EXPIRATION_INACTIVE);</span><br><span>@@ -1091,6 +1093,7 @@</span><br><span>               talloc_free(xua);</span><br><span>            /* Send RLSD to peer */</span><br><span>              xua_gen_relre_and_send(conn, SCCP_RELEASE_CAUSE_EXPIRATION_INACTIVE, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+           /* start release timer */</span><br><span>            conn_start_rel_timer(conn);</span><br><span>          osmo_fsm_inst_state_chg(fi, S_DISCONN_PEND, 0, 0);</span><br><span>           break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/16961">change 16961</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/16961"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ieb02dedba312ab76890e943934ce6a1e2fe61f74 </div>
<div style="display:none"> Gerrit-Change-Number: 16961 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>