<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/16939">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">measurment: write irssi_full_sum variable correctly<br><br>The variable irssi_full_sum is not populated with a dummy value when we<br>are not able to compute irssi_full_sum. Instead we mistakenly write<br>MEASUREMENT_DUMMY_IRSSI to ber_full_sum, which is wrong<br><br>Change-Id: I44d7cb48e3c68ab1b48c78cceb9381ce3e39d7e8<br>Related: OS#2987<br>---<br>M src/common/measurement.c<br>M tests/meas/meas_test.ok<br>M tests/meas/meas_testcases.h<br>3 files changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/39/16939/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/measurement.c b/src/common/measurement.c</span><br><span>index 3e0daf1..2fdd524 100644</span><br><span>--- a/src/common/measurement.c</span><br><span>+++ b/src/common/measurement.c</span><br><span>@@ -655,7 +655,7 @@</span><br><span>     ber_full_sum = ber_full_sum / num_ul_meas;</span><br><span> </span><br><span>       if (!irssi_full_sum)</span><br><span style="color: hsl(0, 100%, 40%);">-            ber_full_sum = MEASUREMENT_DUMMY_IRSSI;</span><br><span style="color: hsl(120, 100%, 40%);">+               irssi_full_sum = MEASUREMENT_DUMMY_IRSSI;</span><br><span>    else</span><br><span>                 irssi_full_sum = irssi_full_sum / num_ul_meas_actual;</span><br><span> </span><br><span>diff --git a/tests/meas/meas_test.ok b/tests/meas/meas_test.ok</span><br><span>index e62bb42..559a8e6 100644</span><br><span>--- a/tests/meas/meas_test.ok</span><br><span>+++ b/tests/meas/meas_test.ok</span><br><span>@@ -585,8 +585,8 @@</span><br><span> meas.ext.toa256_max      |      0 |      0</span><br><span> meas.ms_toa256           |      0 |      0</span><br><span> meas.ext.toa256_std_dev  |      0 |      0</span><br><span style="color: hsl(0, 100%, 40%);">-meas.ul_res.full.rx_lev  |     63 |     63</span><br><span style="color: hsl(0, 100%, 40%);">-meas.ul_res.full.rx_qual |      3 |      3</span><br><span style="color: hsl(120, 100%, 40%);">+meas.ul_res.full.rx_lev  |      1 |      1</span><br><span style="color: hsl(120, 100%, 40%);">+meas.ul_res.full.rx_qual |      7 |      7</span><br><span> </span><br><span> </span><br><span> ===========================================================</span><br><span>diff --git a/tests/meas/meas_testcases.h b/tests/meas/meas_testcases.h</span><br><span>index fefa34f..d7eee5c 100644</span><br><span>--- a/tests/meas/meas_testcases.h</span><br><span>+++ b/tests/meas/meas_testcases.h</span><br><span>@@ -131,8 +131,8 @@</span><br><span>         .pchan = GSM_PCHAN_TCH_F,</span><br><span>    .res = {</span><br><span>             .success = 1,</span><br><span style="color: hsl(0, 100%, 40%);">-           .rx_lev_full = 63,</span><br><span style="color: hsl(0, 100%, 40%);">-              .rx_qual_full = 3,</span><br><span style="color: hsl(120, 100%, 40%);">+            .rx_lev_full = 1,</span><br><span style="color: hsl(120, 100%, 40%);">+             .rx_qual_full = 7,</span><br><span>           .toa256_mean = 0,</span><br><span>            .toa256_max = 0,</span><br><span>             .toa256_min = 0,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/16939">change 16939</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/16939"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I44d7cb48e3c68ab1b48c78cceb9381ce3e39d7e8 </div>
<div style="display:none"> Gerrit-Change-Number: 16939 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>