<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/16954">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">VTY: mark 'subscriber create imsi' command as deprecated<br><br>Neither it should appear in the interactive VTY nor in documentation.<br><br>Change-Id: I208faab69a40948af5d081edbeaf75f586dfb2e4<br>---<br>M doc/manuals/vty/msc_vty_reference.xml<br>M src/libmsc/msc_vty.c<br>2 files changed, 6 insertions(+), 23 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/54/16954/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/doc/manuals/vty/msc_vty_reference.xml b/doc/manuals/vty/msc_vty_reference.xml</span><br><span>index d5273d4..09ad67d 100644</span><br><span>--- a/doc/manuals/vty/msc_vty_reference.xml</span><br><span>+++ b/doc/manuals/vty/msc_vty_reference.xml</span><br><span>@@ -697,14 +697,6 @@</span><br><span>         <param name='expired' doc='Delete all expired SMS' /></span><br><span>       </params></span><br><span>     </command></span><br><span style="color: hsl(0, 100%, 40%);">-    <command id='subscriber create imsi ID'></span><br><span style="color: hsl(0, 100%, 40%);">-      <params></span><br><span style="color: hsl(0, 100%, 40%);">-        <param name='subscriber' doc='Operations on a Subscriber' /></span><br><span style="color: hsl(0, 100%, 40%);">-        <param name='create' doc='Create new subscriber' /></span><br><span style="color: hsl(0, 100%, 40%);">-        <param name='imsi' doc='Identify the subscriber by his IMSI' /></span><br><span style="color: hsl(0, 100%, 40%);">-        <param name='ID' doc='Identifier for the subscriber' /></span><br><span style="color: hsl(0, 100%, 40%);">-      </params></span><br><span style="color: hsl(0, 100%, 40%);">-    </command></span><br><span>     <command id='subscriber (msisdn|extension|imsi|tmsi|id) ID sms sender (msisdn|extension|imsi|tmsi|id) SENDER_ID send .LINE'></span><br><span>       <params></span><br><span>         <param name='subscriber' doc='Operations on a Subscriber' /></span><br><span>@@ -1550,14 +1542,6 @@</span><br><span>         <param name='expired' doc='Delete all expired SMS' /></span><br><span>       </params></span><br><span>     </command></span><br><span style="color: hsl(0, 100%, 40%);">-    <command id='subscriber create imsi ID'></span><br><span style="color: hsl(0, 100%, 40%);">-      <params></span><br><span style="color: hsl(0, 100%, 40%);">-        <param name='subscriber' doc='Operations on a Subscriber' /></span><br><span style="color: hsl(0, 100%, 40%);">-        <param name='create' doc='Create new subscriber' /></span><br><span style="color: hsl(0, 100%, 40%);">-        <param name='imsi' doc='Identify the subscriber by his IMSI' /></span><br><span style="color: hsl(0, 100%, 40%);">-        <param name='ID' doc='Identifier for the subscriber' /></span><br><span style="color: hsl(0, 100%, 40%);">-      </params></span><br><span style="color: hsl(0, 100%, 40%);">-    </command></span><br><span>     <command id='subscriber (msisdn|extension|imsi|tmsi|id) ID sms sender (msisdn|extension|imsi|tmsi|id) SENDER_ID send .LINE'></span><br><span>       <params></span><br><span>         <param name='subscriber' doc='Operations on a Subscriber' /></span><br><span>diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c</span><br><span>index e8fff0b..7be74d0 100644</span><br><span>--- a/src/libmsc/msc_vty.c</span><br><span>+++ b/src/libmsc/msc_vty.c</span><br><span>@@ -1380,13 +1380,12 @@</span><br><span>        return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-DEFUN(subscriber_create,</span><br><span style="color: hsl(0, 100%, 40%);">-      subscriber_create_cmd,</span><br><span style="color: hsl(0, 100%, 40%);">-      "subscriber create imsi ID",</span><br><span style="color: hsl(0, 100%, 40%);">-    "Operations on a Subscriber\n" \</span><br><span style="color: hsl(0, 100%, 40%);">-      "Create new subscriber\n" \</span><br><span style="color: hsl(0, 100%, 40%);">-   "Identify the subscriber by his IMSI\n" \</span><br><span style="color: hsl(0, 100%, 40%);">-     "Identifier for the subscriber\n")</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN_DEPRECATED(subscriber_create, subscriber_create_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+               "subscriber create imsi ID",</span><br><span style="color: hsl(120, 100%, 40%);">+                "Operations on a Subscriber\n"</span><br><span style="color: hsl(120, 100%, 40%);">+              "Create new subscriber\n"</span><br><span style="color: hsl(120, 100%, 40%);">+           "Identify the subscriber by his IMSI\n"</span><br><span style="color: hsl(120, 100%, 40%);">+             "Identifier for the subscriber\n")</span><br><span> {</span><br><span>   vty_out(vty, "%% 'subscriber create' now needs to be done at osmo-hlr%s",</span><br><span>          VTY_NEWLINE);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/16954">change 16954</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/16954"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I208faab69a40948af5d081edbeaf75f586dfb2e4 </div>
<div style="display:none"> Gerrit-Change-Number: 16954 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>