<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16926">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsup_protocol.hrl: SM-RP-MR IE is mandatory for READY-FOR-SM messages<br><br>Change-Id: I09b6b8afb1c0d28d4bf214fb8f01c21c895b8546<br>---<br>M include/gsup_protocol.hrl<br>M test/gsup_encode_decode_test.erl<br>2 files changed, 12 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/gsup_protocol.hrl b/include/gsup_protocol.hrl</span><br><span>index e304654..3c867d6 100644</span><br><span>--- a/include/gsup_protocol.hrl</span><br><span>+++ b/include/gsup_protocol.hrl</span><br><span>@@ -198,9 +198,9 @@</span><br><span>   16#28 => #{message_type => mt_forward_sm_req, mandatory => [sm_rp_mr, sm_rp_da, sm_rp_oa, sm_rp_ui], optional => [sm_rp_mms]},</span><br><span>   16#29 => #{message_type => mt_forward_sm_err, mandatory => [sm_rp_mr, sm_rp_cause], optional => [sm_rp_ui]},</span><br><span>   16#2a => #{message_type => mt_forward_sm_res, mandatory => [sm_rp_mr], optional => [sm_rp_ui]},</span><br><span style="color: hsl(0, 100%, 40%);">-  16#2c => #{message_type => ready_for_sm_req, mandatory => [sm_alert_reason]},</span><br><span style="color: hsl(0, 100%, 40%);">-  16#2d => #{message_type => ready_for_sm_err, mandatory => [sm_rp_cause], optional => [sm_rp_ui]},</span><br><span style="color: hsl(0, 100%, 40%);">-  16#2e => #{message_type => ready_for_sm_res, mandatory => []},</span><br><span style="color: hsl(120, 100%, 40%);">+  16#2c => #{message_type => ready_for_sm_req, mandatory => [sm_rp_mr, sm_alert_reason]},</span><br><span style="color: hsl(120, 100%, 40%);">+  16#2d => #{message_type => ready_for_sm_err, mandatory => [sm_rp_mr, sm_rp_cause], optional => [sm_rp_ui]},</span><br><span style="color: hsl(120, 100%, 40%);">+  16#2e => #{message_type => ready_for_sm_res, mandatory => [sm_rp_mr]},</span><br><span>   16#30 => #{message_type => check_imei_req, mandatory => [imei]},</span><br><span>   16#31 => #{message_type => check_imei_err, mandatory => [cause]},</span><br><span>   16#32 => #{message_type => check_imei_res, mandatory => [imei_check_result]},</span><br><span>diff --git a/test/gsup_encode_decode_test.erl b/test/gsup_encode_decode_test.erl</span><br><span>index c0d3a21..65863c7 100644</span><br><span>--- a/test/gsup_encode_decode_test.erl</span><br><span>+++ b/test/gsup_encode_decode_test.erl</span><br><span>@@ -375,9 +375,16 @@</span><br><span>   ?assertEqual(Bin, gsup_protocol:encode(Map)).</span><br><span> </span><br><span> ready_for_sm_req_test() -></span><br><span style="color: hsl(0, 100%, 40%);">-  Bin = <<16#2c, ?TEST_IMSI_IE, 16#46, 16#01, 16#02>>,</span><br><span style="color: hsl(120, 100%, 40%);">+  Bin = <<16#2c, ?TEST_IMSI_IE,</span><br><span style="color: hsl(120, 100%, 40%);">+    16#40, 16#01, %% SM-RP-MR</span><br><span style="color: hsl(120, 100%, 40%);">+      16#41,</span><br><span style="color: hsl(120, 100%, 40%);">+    16#46, 16#01, %% Alert reason</span><br><span style="color: hsl(120, 100%, 40%);">+      16#02</span><br><span style="color: hsl(120, 100%, 40%);">+  >>,</span><br><span>   Map = #{imsi => <<"123456789012345">>,</span><br><span style="color: hsl(0, 100%, 40%);">-                   message_type => ready_for_sm_req,sm_alert_reason => 2},</span><br><span style="color: hsl(120, 100%, 40%);">+                   message_type => ready_for_sm_req,</span><br><span style="color: hsl(120, 100%, 40%);">+                   sm_rp_mr => 65,</span><br><span style="color: hsl(120, 100%, 40%);">+                   sm_alert_reason => 2},</span><br><span>   ?assertEqual(Map, gsup_protocol:decode(Bin)),</span><br><span>   ?assertEqual(Bin, gsup_protocol:encode(Map)).</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16926">change 16926</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/erlang/osmo_gsup/+/16926"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: erlang/osmo_gsup </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I09b6b8afb1c0d28d4bf214fb8f01c21c895b8546 </div>
<div style="display:none"> Gerrit-Change-Number: 16926 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>