<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16963">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MSC: add a test case to check T3212 expiration during paging<br><br>Long story short: some time ago I noticed that OsmoMSC crashes if<br>T3212 expires during the Paging procedure. This is not the case<br>anymore (as the test case shows) and apparently the bug has been<br>fixed, hovewer I believe it makes sense to add this test case.<br><br>Change-Id: If9147ae8b07d5120d2853b9acda2313910ac48be<br>---<br>M msc/MSC_Tests.ttcn<br>M msc/MSC_Tests_Iu.ttcn<br>M msc/expected-results.xml<br>3 files changed, 50 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index ccfc154..cf91b1e 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -5896,6 +5896,44 @@</span><br><span> vc_conn.done;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify the case when T3212 expires during Paging procedure, just before the receipt</span><br><span style="color: hsl(120, 100%, 40%);">+ * of Paging Response. This used to provoke a NULL-pointer dereference in old versions</span><br><span style="color: hsl(120, 100%, 40%);">+ * of OsmoMSC, but apparently the bug has been fixed, and we're safe now. */</span><br><span style="color: hsl(120, 100%, 40%);">+friend function f_tc_lu_and_expire_while_paging(charstring id, BSC_ConnHdlrPars pars)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on BSC_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var charstring imsi := hex2str(pars.imsi);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_handler(pars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Perform location update */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_perform_lu();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ran_register_imsi(g_pars.imsi, g_pars.tmsi);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_create_gsup_expect(hex2str(g_pars.imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initiate paging procedure from the VTY */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_transceive(MSCVTY, "subscriber imsi " & imsi & " paging");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_expect_paging();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Emulate T3212 expiration during paging (we don't want to wait, right?) */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_transceive(MSCVTY, "subscriber imsi " & imsi & " expire");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* MS sends PAGING RESPONSE, *old* OsmoMSC crashes here... */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_establish_fully(EST_TYPE_PAG_RESP);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* The recent OsmoMSC keeps subscriber in its VLR unless the Paging is completed.</span><br><span style="color: hsl(120, 100%, 40%);">+ * In this case we do not send anything and just wait for a Clear Command. */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_expect_clear();</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_lu_and_expire_while_paging() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_tc_lu_and_expire_while_paging), 7);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> control {</span><br><span> execute( TC_cr_before_reset() );</span><br><span> execute( TC_lu_imsi_noauth_tmsi() );</span><br><span>@@ -6034,6 +6072,7 @@</span><br><span> }</span><br><span> execute( TC_invalid_mgcp_crash() );</span><br><span> execute( TC_mm_id_resp_no_identity() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_lu_and_expire_while_paging() );</span><br><span> }</span><br><span> </span><br><span> </span><br><span>diff --git a/msc/MSC_Tests_Iu.ttcn b/msc/MSC_Tests_Iu.ttcn</span><br><span>index 72bbf03..febae09 100644</span><br><span>--- a/msc/MSC_Tests_Iu.ttcn</span><br><span>+++ b/msc/MSC_Tests_Iu.ttcn</span><br><span>@@ -523,6 +523,14 @@</span><br><span> vc_conn.done;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_iu_lu_and_expire_while_paging() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init(3);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_tc_lu_and_expire_while_paging), 1055,</span><br><span style="color: hsl(120, 100%, 40%);">+ ran_idx := 2, ran_is_geran := false);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> control {</span><br><span> execute( TC_iu_lu_imsi_reject() );</span><br><span> execute( TC_iu_lu_imsi_timeout_gsup() );</span><br><span>@@ -582,6 +590,7 @@</span><br><span> execute( TC_iu_multi_lu_and_mt_ussd() );</span><br><span> </span><br><span> execute( TC_iu_lu_with_invalid_mcc_mnc() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_iu_lu_and_expire_while_paging() );</span><br><span> </span><br><span> /* TODO: Iu + SGsAP related tests, e.g. paging on IuCS */</span><br><span> </span><br><span>diff --git a/msc/expected-results.xml b/msc/expected-results.xml</span><br><span>index 68e2958..2d24d43 100644</span><br><span>--- a/msc/expected-results.xml</span><br><span>+++ b/msc/expected-results.xml</span><br><span>@@ -122,6 +122,7 @@</span><br><span> <testcase classname='MSC_Tests' name='TC_lu_imsi_auth_tmsi_encr_3_1_log_msc_debug' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_mo_cc_bssmap_clear' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_lu_and_mt_call_osmux' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='MSC_Tests' name='TC_lu_and_expire_while_paging' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests_Iu' name='TC_iu_lu_imsi_reject' time='MASKED'></span><br><span> <failure type='fail-verdict'>Tguard timeout</span><br><span> MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part</span><br><span>@@ -219,5 +220,6 @@</span><br><span> <testcase classname='MSC_Tests_Iu' name='TC_iu_multi_lu_and_mo_ussd' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests_Iu' name='TC_iu_multi_lu_and_mt_ussd' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests_Iu' name='TC_iu_lu_with_invalid_mcc_mnc' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='MSC_Tests_Iu' name='TC_iu_lu_and_expire_while_paging' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests_Iu' name='TC_mo_cc_iu_release' time='MASKED'/></span><br><span> </testsuite></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16963">change 16963</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16963"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If9147ae8b07d5120d2853b9acda2313910ac48be </div>
<div style="display:none"> Gerrit-Change-Number: 16963 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>