<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/16900">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sccp: Convert ifelse to switch statement<br><br>Change-Id: I1f3129f5b949fc70913e8103ef17c696002b8ed2<br>---<br>M src/sccp2sua.c<br>1 file changed, 8 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sccp2sua.c b/src/sccp2sua.c</span><br><span>index 1106888..e68662f 100644</span><br><span>--- a/src/sccp2sua.c</span><br><span>+++ b/src/sccp2sua.c</span><br><span>@@ -712,13 +712,14 @@</span><br><span> oneopt = opt_start;</span><br><span> </span><br><span> while (oneopt < msg->tail) {</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t opt_type = oneopt[0];</span><br><span style="color: hsl(120, 100%, 40%);">+ enum sccp_parameter_name_codes opt_type = oneopt[0];</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t opt_len;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint16_t opt_len16;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (opt_type == SCCP_PNC_END_OF_OPTIONAL)</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (opt_type) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case SCCP_PNC_END_OF_OPTIONAL:</span><br><span> return xua;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (opt_type == SCCP_PNC_LONG_DATA) {</span><br><span style="color: hsl(0, 100%, 40%);">- uint16_t opt_len16;</span><br><span style="color: hsl(120, 100%, 40%);">+ case SCCP_PNC_LONG_DATA:</span><br><span> /* two byte length field */</span><br><span> if (oneopt + 2 > msg->tail)</span><br><span> return NULL;</span><br><span>@@ -727,8 +728,8 @@</span><br><span> return NULL;</span><br><span> xua_msg_add_sccp_opt(xua, opt_type, opt_len16, oneopt+3);</span><br><span> oneopt += 3 + opt_len16;</span><br><span style="color: hsl(0, 100%, 40%);">- } else {</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t opt_len;</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span> /* one byte length field */</span><br><span> if (oneopt + 1 > msg->tail)</span><br><span> return NULL;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/16900">change 16900</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/16900"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1f3129f5b949fc70913e8103ef17c696002b8ed2 </div>
<div style="display:none"> Gerrit-Change-Number: 16900 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>