<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/16892">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">logging: use meaningful default loglevels<br><br>Some logging categories use LOGL_INFO or even LOGL_DEBUG. Lets set those<br>to LOGL_NOTICE to have a less crowded default log output.<br><br>Change-Id: I3faefccae2218b17bd942bc2afac7d8e515897b7<br>Related: OS#2577<br>---<br>M src/host/layer23/src/common/logging.c<br>M src/host/virt_phy/src/logging.c<br>2 files changed, 20 insertions(+), 20 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/92/16892/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/layer23/src/common/logging.c b/src/host/layer23/src/common/logging.c</span><br><span>index ed79991..636a615 100644</span><br><span>--- a/src/host/layer23/src/common/logging.c</span><br><span>+++ b/src/host/layer23/src/common/logging.c</span><br><span>@@ -36,7 +36,7 @@</span><br><span> .name = "DCS",</span><br><span> .description = "Cell selection",</span><br><span> .color = "\033[34m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DNB] = {</span><br><span> .name = "DNB",</span><br><span>@@ -48,54 +48,54 @@</span><br><span> .name = "DPLMN",</span><br><span> .description = "PLMN selection",</span><br><span> .color = "\033[32m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DRR] = {</span><br><span> .name = "DRR",</span><br><span> .description = "Radio Resource",</span><br><span> .color = "\033[1;34m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DMM] = {</span><br><span> .name = "DMM",</span><br><span> .description = "Mobility Management",</span><br><span> .color = "\033[1;32m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DCC] = {</span><br><span> .name = "DCC",</span><br><span> .description = "Call Control",</span><br><span> .color = "\033[1;33m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DSS] = {</span><br><span> .name = "DSS",</span><br><span> .description = "Supplenmentary Services",</span><br><span> .color = "\033[1;35m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DSMS] = {</span><br><span> .name = "DSMS",</span><br><span> .description = "Short Message Service",</span><br><span> .color = "\033[1;37m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DMNCC] = {</span><br><span> .name = "DMNCC",</span><br><span> .description = "Mobile Network Call Control",</span><br><span> .color = "\033[1;37m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DMEAS] = {</span><br><span> .name = "DMEAS",</span><br><span> .description = "MEasurement Reporting",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DPAG] = {</span><br><span> .name = "DPAG",</span><br><span> .description = "Paging",</span><br><span> .color = "\033[33m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DL1C] = {</span><br><span> .name = "DL1C",</span><br><span>@@ -107,37 +107,37 @@</span><br><span> .name = "DSAP",</span><br><span> .description = "SAP Control",</span><br><span> .color = "\033[1;31m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DSUM] = {</span><br><span> .name = "DSUM",</span><br><span> .description = "Summary of Process",</span><br><span> .color = "\033[1;37m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DSIM] = {</span><br><span> .name = "DSIM",</span><br><span> .description = "SIM client",</span><br><span> .color = "\033[0;35m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DGPS] = {</span><br><span> .name = "DGPS",</span><br><span> .description = "GPS",</span><br><span> .color = "\033[1;35m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DMOB] = {</span><br><span> .name = "DMOB",</span><br><span> .description = "Mobile",</span><br><span> .color = "\033[1;35m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DPRIM] = {</span><br><span> .name = "DPRIM",</span><br><span> .description = "PRIM",</span><br><span> .color = "\033[1;32m",</span><br><span style="color: hsl(0, 100%, 40%);">- .enabled = 1, .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DLUA] = {</span><br><span> .name = "DLUA",</span><br><span>diff --git a/src/host/virt_phy/src/logging.c b/src/host/virt_phy/src/logging.c</span><br><span>index aa3b88a..e8370cc 100644</span><br><span>--- a/src/host/virt_phy/src/logging.c</span><br><span>+++ b/src/host/virt_phy/src/logging.c</span><br><span>@@ -70,28 +70,28 @@</span><br><span> .description = "Layer 1 Control",</span><br><span> .color = "\033[1;31m",</span><br><span> .enabled = 1,</span><br><span style="color: hsl(0, 100%, 40%);">- .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DL1P] = {</span><br><span> .name = "DL1P",</span><br><span> .description = "Layer 1 Data",</span><br><span> .color = "\033[1;31m",</span><br><span> .enabled = 1,</span><br><span style="color: hsl(0, 100%, 40%);">- .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DVIRPHY] = {</span><br><span> .name = "DVIRPHY",</span><br><span> .description = "Virtual Layer 1 Interface",</span><br><span> .color = "\033[1;31m",</span><br><span> .enabled = 1,</span><br><span style="color: hsl(0, 100%, 40%);">- .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> [DMAIN] = {</span><br><span> .name = "DMAIN",</span><br><span> .description = "Main Program / Data Structures",</span><br><span> .color = "\033[1;32m",</span><br><span> .enabled = 1,</span><br><span style="color: hsl(0, 100%, 40%);">- .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ .loglevel = LOGL_NOTICE,</span><br><span> },</span><br><span> };</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/16892">change 16892</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/16892"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3faefccae2218b17bd942bc2afac7d8e515897b7 </div>
<div style="display:none"> Gerrit-Change-Number: 16892 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>