<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16882">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MSC/SMPP: introduce TC_smpp_mo_sms_rp_error for OS#4351<br><br>This test case reproduces the problem described in OS#4351:<br><br> 1. MS/UE submits a MO SMS which it getting touted to an ESME;<br> 2. MSC prematurely responds with RP-ACK to the MS/UE;<br> 3. ESME responds with DELIVER-SM error;<br> 4. SMS transaction is already terminated (by RP-ACK).<br><br>Expected behaviour:<br><br> 1. MS/UE submits a MO SMS which it getting touted to an ESME;<br> 2. ESME responds with DELIVER-SM error;<br> 3. MSC terminates the SMS transaction with RP-ERROR.<br><br>Change-Id: I33c6ea0ffdf8b8a45f587d690bdceb38fc42c898<br>Related: OS#4351<br>---<br>M msc/MSC_Tests.ttcn<br>M msc/expected-results.xml<br>2 files changed, 46 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index 13cb8f4..94fac74 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -2160,6 +2160,50 @@</span><br><span> f_vty_config2(MSCVTY, { "smpp", "esme msc_tester"}, "no default-route");</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Test case for OS#4351: make sure that RP-ERROR from ESME is properly sent to the MS/UE */</span><br><span style="color: hsl(120, 100%, 40%);">+friend function f_tc_smpp_mo_sms_rp_error(charstring id, BSC_ConnHdlrPars pars)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on BSC_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var SmsParameters spars := valueof(t_SmsPars);</span><br><span style="color: hsl(120, 100%, 40%);">+ var SMPP_PDU smpp_pdu;</span><br><span style="color: hsl(120, 100%, 40%);">+ timer T := 3.0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_handler(pars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Perform location update */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_perform_lu();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* MS/UE submits a MO SMS */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_establish_fully(EST_TYPE_MO_SMS);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mo_sms_submit(spars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* ESME responds with an error (Invalid Destination Address) */</span><br><span style="color: hsl(120, 100%, 40%);">+ T.start;</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] SMPP.receive(tr_SMPP(c_SMPP_command_id_deliver_sm, ESME_ROK, body := ?)) -> value smpp_pdu {</span><br><span style="color: hsl(120, 100%, 40%);">+ SMPP.send(ts_SMPP_DELIVER_SM_resp(ESME_RINVDSTADR, smpp_pdu.header.seq_num));</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] SMPP.receive(tr_SMPP(c_SMPP_command_id_alert_notification, ESME_ROK)) { repeat; }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] T.timeout {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Timeout waiting for SMPP DELIVER-SM");</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Expect RP-ERROR on BSSAP interface */</span><br><span style="color: hsl(120, 100%, 40%);">+ spars.exp_rp_err := 1; /* FIXME: GSM411_RP_CAUSE_MO_NUM_UNASSIGNED */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mo_sms_wait_rp_ack(spars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_expect_clear();</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_smpp_mo_sms_rp_error() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config2(MSCVTY, { "smpp", "esme msc_tester"}, "default-route");</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_tc_smpp_mo_sms_rp_error), 45);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config2(MSCVTY, { "smpp", "esme msc_tester"}, "no default-route");</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> </span><br><span> /* Test MO-SMS from MS/BTS/BSC towards HLR (via GSUP) */</span><br><span> friend function f_tc_gsup_mo_sms(charstring id, BSC_ConnHdlrPars pars)</span><br><span>@@ -5904,6 +5948,7 @@</span><br><span> execute( TC_lu_and_mt_sms_paging_and_nothing() );</span><br><span> execute( TC_lu_and_mt_sms_paging_repeated() );</span><br><span> execute( TC_smpp_mo_sms() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_smpp_mo_sms_rp_error() );</span><br><span> execute( TC_smpp_mt_sms() );</span><br><span> </span><br><span> execute( TC_gsup_mo_sms() );</span><br><span>diff --git a/msc/expected-results.xml b/msc/expected-results.xml</span><br><span>index e2cca45..68e2958 100644</span><br><span>--- a/msc/expected-results.xml</span><br><span>+++ b/msc/expected-results.xml</span><br><span>@@ -55,6 +55,7 @@</span><br><span> <testcase classname='MSC_Tests' name='TC_lu_and_mt_sms' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_lu_and_mt_sms_paging_and_nothing' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_smpp_mo_sms' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='MSC_Tests' name='TC_smpp_mo_sms_rp_error' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_smpp_mt_sms' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_gsup_mo_sms' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_gsup_mo_smma' time='MASKED'/></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16882">change 16882</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16882"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I33c6ea0ffdf8b8a45f587d690bdceb38fc42c898 </div>
<div style="display:none"> Gerrit-Change-Number: 16882 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>