<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16790">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">hlr: add TC_gsup_sai_num_auth_vectors<br><br>TC_gsup_sai_num_auth_vectors tests the GSUP IE<br>GSUP_IE_NUM_VECTORS_REQ which allows the client to<br>ask for a specific amount of auth tuples in a<br>Send Auth Info request.<br><br>Change-Id: I10a523cbaf08fe42924ffd0dc498496fdc76395f<br>---<br>M hlr/HLR_Tests.ttcn<br>1 file changed, 61 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn</span><br><span>index 50109a6..4caa88e 100644</span><br><span>--- a/hlr/HLR_Tests.ttcn</span><br><span>+++ b/hlr/HLR_Tests.ttcn</span><br><span>@@ -50,6 +50,9 @@</span><br><span> charstring mp_hlr_ip := "127.0.0.1";</span><br><span> integer mp_hlr_gsup_port := 4222;</span><br><span> integer mp_hlr_ctrl_port := 4259;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* how many auth tuples are expected</span><br><span style="color: hsl(120, 100%, 40%);">+ when IE ts_GSUP_IE_NUM_VECTORS_REQ is absent */</span><br><span style="color: hsl(120, 100%, 40%);">+ integer mp_default_num_auth_tuples := 5;</span><br><span> };</span><br><span> </span><br><span> type record HlrSubscrAud2G {</span><br><span>@@ -395,8 +398,9 @@</span><br><span> </span><br><span> /* perform SendAuthInfo for given imsi, return the GSUP response/error */</span><br><span> function f_perform_SAI(hexstring imsi, template (omit) integer exp_err_cause := omit,</span><br><span style="color: hsl(0, 100%, 40%);">- boolean is_eps := false)</span><br><span style="color: hsl(120, 100%, 40%);">+ boolean is_eps := false, template (omit) integer num_auth_tuple := omit)</span><br><span> runs on HLR_ConnHdlr return GSUP_PDU {</span><br><span style="color: hsl(120, 100%, 40%);">+ var template GSUP_PDU sai_msg;</span><br><span> var GSUP_PDU ret;</span><br><span> timer T := 3.0;</span><br><span> var boolean exp_fail := false;</span><br><span>@@ -405,10 +409,17 @@</span><br><span> }</span><br><span> </span><br><span> if (is_eps) {</span><br><span style="color: hsl(0, 100%, 40%);">- GSUP.send(ts_GSUP_SAI_REQ_EPS(imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+ sai_msg := ts_GSUP_SAI_REQ_EPS(imsi);</span><br><span> } else {</span><br><span style="color: hsl(0, 100%, 40%);">- GSUP.send(valueof(ts_GSUP_SAI_REQ(imsi)));</span><br><span style="color: hsl(120, 100%, 40%);">+ sai_msg := ts_GSUP_SAI_REQ(imsi);</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not istemplatekind(num_auth_tuple, "omit")) {</span><br><span style="color: hsl(120, 100%, 40%);">+ sai_msg.ies := valueof(sai_msg.ies) & {</span><br><span style="color: hsl(120, 100%, 40%);">+ valueof(ts_GSUP_IE_NUM_VECTORS_REQ(int2oct(valueof(num_auth_tuple), 1)))</span><br><span style="color: hsl(120, 100%, 40%);">+ };</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ GSUP.send(sai_msg);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> T.start;</span><br><span> alt {</span><br><span> [exp_fail] GSUP.receive(tr_GSUP_SAI_ERR(imsi, exp_err_cause)) -> value ret {</span><br><span>@@ -714,7 +725,8 @@</span><br><span> if (ispresent(g_pars.sub.aud3g)) {</span><br><span> f_ensure_amf_separation_bit(res, '0'B);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- /* TODO: match if tuple[s] matches expectation */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_count_auth_tuples(res, mp_default_num_auth_tuples);</span><br><span> setverdict(pass);</span><br><span> }</span><br><span> testcase TC_gsup_sai() runs on test_CT {</span><br><span>@@ -729,6 +741,31 @@</span><br><span> setverdict(pass);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* test SAI for a number of different subscriber cases (algo, 2g/3g, ...) */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_gsup_sai_num_auth_vectors() runs on HLR_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var GSUP_PDU res;</span><br><span style="color: hsl(120, 100%, 40%);">+ res := f_perform_SAI(g_pars.sub.imsi, num_auth_tuple := 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_count_auth_tuples(res, 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ res := f_perform_SAI(g_pars.sub.imsi, num_auth_tuple := 4);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_count_auth_tuples(res, 4);</span><br><span style="color: hsl(120, 100%, 40%);">+ res := f_perform_SAI(g_pars.sub.imsi, num_auth_tuple := 5);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_count_auth_tuples(res, 5);</span><br><span style="color: hsl(120, 100%, 40%);">+ res := f_perform_SAI(g_pars.sub.imsi, num_auth_tuple := 254);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_count_auth_tuples(res, 5);</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_gsup_sai_num_auth_vectors() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var HlrSubscriberList sl;</span><br><span style="color: hsl(120, 100%, 40%);">+ var GSUP_PDU res;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init(false);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ sl := f_gen_subs();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_start_handler_per_sub(refers(f_TC_gsup_sai_num_auth_vectors), sl);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> private function f_ensure_amf_separation_bit(GSUP_PDU res, BIT1 sep_bit)</span><br><span> {</span><br><span> for (var integer i := 0; i < lengthof(res.ies); i := i+1) {</span><br><span>@@ -749,6 +786,25 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+private function f_count_auth_tuples(GSUP_PDU res, template (omit) integer expected_auth_tuples := omit)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer auth_tuples := 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ for (var integer i := 0; i < lengthof(res.ies); i := i+1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ var GSUP_IE tuple := res.ies[i];</span><br><span style="color: hsl(120, 100%, 40%);">+ if (tuple.tag == OSMO_GSUP_AUTH_TUPLE_IE) {</span><br><span style="color: hsl(120, 100%, 40%);">+ auth_tuples := auth_tuples + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if ((not istemplatekind(expected_auth_tuples, "omit")) and</span><br><span style="color: hsl(120, 100%, 40%);">+ not match(auth_tuples, valueof(expected_auth_tuples))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Did not received expected number of auth tuples. Expected ",</span><br><span style="color: hsl(120, 100%, 40%);">+ mp_default_num_auth_tuples,</span><br><span style="color: hsl(120, 100%, 40%);">+ " but received ", auth_tuples);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* test SAI for a number of different subscriber cases (algo, 2g/3g, ...) */</span><br><span> private function f_TC_gsup_sai_eps() runs on HLR_ConnHdlr {</span><br><span> var GSUP_PDU res;</span><br><span>@@ -1471,6 +1527,7 @@</span><br><span> control {</span><br><span> execute( TC_gsup_sai_err_invalid_imsi() );</span><br><span> execute( TC_gsup_sai() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_gsup_sai_num_auth_vectors() );</span><br><span> execute( TC_gsup_sai_eps() );</span><br><span> execute( TC_gsup_ul_unknown_imsi() );</span><br><span> execute( TC_gsup_sai_err_unknown_imsi() );</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16790">change 16790</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16790"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I10a523cbaf08fe42924ffd0dc498496fdc76395f </div>
<div style="display:none"> Gerrit-Change-Number: 16790 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>