<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16883">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MSC/SMPP: fix RP-ACK expectations in TC_smpp_mo_sms<br><br>The MSC shall not send RP-ACK before the response from ESME.<br><br>Change-Id: Ide1376cae8e75412039b7dc9f0b8bb390eab2280<br>Related: OS#4351<br>---<br>M msc/MSC_Tests.ttcn<br>1 file changed, 6 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index 94fac74..ccfc154 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -2109,9 +2109,10 @@</span><br><span> </span><br><span>         /* Perform location update so IMSI is known + registered in MSC/VLR */</span><br><span>       f_perform_lu();</span><br><span style="color: hsl(0, 100%, 40%);">- f_establish_fully(EST_TYPE_MO_SMS);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_mo_sms(spars);</span><br><span style="color: hsl(120, 100%, 40%);">+      /* MS/UE submits a MO SMS */</span><br><span style="color: hsl(120, 100%, 40%);">+  f_establish_fully(EST_TYPE_MO_SMS);</span><br><span style="color: hsl(120, 100%, 40%);">+   f_mo_sms_submit(spars);</span><br><span> </span><br><span>  var SMPP_PDU smpp;</span><br><span>   var template SMPP_PDU tr_smpp := tr_SMPP(c_SMPP_command_id_deliver_sm, ESME_ROK);</span><br><span>@@ -2149,6 +2150,9 @@</span><br><span>    [] SMPP.receive(tr_SMPP(c_SMPP_command_id_alert_notification, ESME_ROK)) { repeat; }</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* MSC terminates the SMS transaction with RP-ACK */</span><br><span style="color: hsl(120, 100%, 40%);">+  f_mo_sms_wait_rp_ack(spars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>       f_expect_clear();</span><br><span> }</span><br><span> testcase TC_smpp_mo_sms() runs on MTC_CT {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16883">change 16883</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16883"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ide1376cae8e75412039b7dc9f0b8bb390eab2280 </div>
<div style="display:none"> Gerrit-Change-Number: 16883 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>