<p>osmith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16845">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mdns_sock.c: fix resource leak of sock<br><br>Fixes: CID#207542<br>Change-Id: I0216b17c3ff67910a39520e2f2a5a16e23575a86<br>---<br>M src/mslookup/mdns_sock.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/45/16845/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mslookup/mdns_sock.c b/src/mslookup/mdns_sock.c</span><br><span>index 5291660..1ca7d32 100644</span><br><span>--- a/src/mslookup/mdns_sock.c</span><br><span>+++ b/src/mslookup/mdns_sock.c</span><br><span>@@ -51,7 +51,7 @@</span><br><span>                                           void *data, unsigned int priv_nr)</span><br><span> {</span><br><span>    struct osmo_mdns_sock *ret;</span><br><span style="color: hsl(0, 100%, 40%);">-     int sock, rc;</span><br><span style="color: hsl(120, 100%, 40%);">+ int sock = -1, rc;</span><br><span>   struct addrinfo hints = {0};</span><br><span>         struct ip_mreq multicast_req = {0};</span><br><span>  in_addr_t iface = INADDR_ANY;</span><br><span>@@ -117,6 +117,8 @@</span><br><span> </span><br><span>      return ret;</span><br><span> error:</span><br><span style="color: hsl(120, 100%, 40%);">+ if (sock != -1)</span><br><span style="color: hsl(120, 100%, 40%);">+               close(sock);</span><br><span>         if (ret->ai)</span><br><span>              freeaddrinfo(ret->ai);</span><br><span>    talloc_free(ret);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16845">change 16845</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/16845"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0216b17c3ff67910a39520e2f2a5a16e23575a86 </div>
<div style="display:none"> Gerrit-Change-Number: 16845 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>