<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/16832">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">logging.c: Add valuestrings for loglevels<br><br>It might be helpful to convert a loglevel into a value string, lets add<br>a function for this.<br><br>Related: OS#2577<br>Change-Id: I81e58dbae9889f1424ff107a22ed0e838bea7f5b<br>---<br>M include/osmocom/core/logging.h<br>M src/logging.c<br>2 files changed, 16 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/32/16832/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h</span><br><span>index 79eec10..2d9dace 100644</span><br><span>--- a/include/osmocom/core/logging.h</span><br><span>+++ b/include/osmocom/core/logging.h</span><br><span>@@ -10,6 +10,8 @@</span><br><span> #include <stdbool.h></span><br><span> #include <osmocom/core/defs.h></span><br><span> #include <osmocom/core/linuxlist.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/utils.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> </span><br><span> /*! Maximum number of logging contexts */</span><br><span> #define LOG_MAX_CTX            8</span><br><span>@@ -105,6 +107,11 @@</span><br><span> #define LOGL_ERROR  7       /*!< error condition, requires user action */</span><br><span> #define LOGL_FATAL  8       /*!< fatal, program aborted */</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string log_level_names[];</span><br><span style="color: hsl(120, 100%, 40%);">+static inline const char *log_level_name(uint8_t val) {</span><br><span style="color: hsl(120, 100%, 40%);">+   return get_value_string(log_level_names, val);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* logging subsystems defined by the library itself */</span><br><span> #define DLGLOBAL       -1      /*!< global logging */</span><br><span> #define DLLAPD             -2      /*!< LAPD implementation */</span><br><span>diff --git a/src/logging.c b/src/logging.c</span><br><span>index 4d6224d..a871cad 100644</span><br><span>--- a/src/logging.c</span><br><span>+++ b/src/logging.c</span><br><span>@@ -64,6 +64,15 @@</span><br><span> void *tall_log_ctx = NULL;</span><br><span> LLIST_HEAD(osmo_log_target_list);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+const struct value_string log_level_names[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+  { LOGL_DEBUG,           "LOGL_DEBUG" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { LOGL_INFO,            "LOGL_INFO" },</span><br><span style="color: hsl(120, 100%, 40%);">+      { LOGL_NOTICE,          "LOGL_NOTICE" },</span><br><span style="color: hsl(120, 100%, 40%);">+    { LOGL_ERROR,           "LOGL_ERROR" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { LOGL_FATAL,           "LOGL_FATAL" },</span><br><span style="color: hsl(120, 100%, 40%);">+     { 0, NULL }</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #if (!EMBEDDED)</span><br><span> /*! This mutex must be held while using osmo_log_target_list or any of its</span><br><span>   log_targets in a multithread program. Prevents race conditions between threads</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/16832">change 16832</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/16832"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I81e58dbae9889f1424ff107a22ed0e838bea7f5b </div>
<div style="display:none"> Gerrit-Change-Number: 16832 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>