<p>osmith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16846">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mdns_rfc.c: fix possible access of uninit. mem<br><br>Fixes: CID#207548<br>Change-Id: Ifa269d8a88d84c01349668cdd8d1f1d24c12c6d8<br>---<br>M src/mslookup/mdns_rfc.c<br>1 file changed, 6 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/46/16846/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mslookup/mdns_rfc.c b/src/mslookup/mdns_rfc.c</span><br><span>index e1fc184..6f39a8e 100644</span><br><span>--- a/src/mslookup/mdns_rfc.c</span><br><span>+++ b/src/mslookup/mdns_rfc.c</span><br><span>@@ -83,7 +83,12 @@</span><br><span>            return NULL;</span><br><span> </span><br><span>     while (*qname) {</span><br><span style="color: hsl(0, 100%, 40%);">-                size_t len = *qname;</span><br><span style="color: hsl(120, 100%, 40%);">+          size_t len;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+         if (i >= qname_max_len)</span><br><span style="color: hsl(120, 100%, 40%);">+                    return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                len = *qname;</span><br><span>                next_label = qname + len + 1;</span><br><span> </span><br><span>            if (next_label >= qname_end || i + len > OSMO_MDNS_RFC_MAX_NAME_LEN)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16846">change 16846</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/16846"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifa269d8a88d84c01349668cdd8d1f1d24c12c6d8 </div>
<div style="display:none"> Gerrit-Change-Number: 16846 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>