<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16798">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: Introduce test TC_chan_rel_sccp_tiar_timeout<br><br>Verify SCCP T(iar) timeout triggers release of established channel.<br><br>Change-Id: Ic2724f62689b99c33e2e5c3a0c2fd022178a788c<br>---<br>M bsc/BSC_Tests.ttcn<br>M bsc/expected-results.xml<br>M library/Osmocom_VTY_Functions.ttcn<br>3 files changed, 41 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 9c8d68d..d020d95 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -97,6 +97,11 @@</span><br><span> /* Osmux is enabled through VTY */</span><br><span> var boolean g_osmux_enabled := false;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /*Configure T(tias) over VTY, seconds */</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer g_bsc_sccp_timer_ias := 7 * 60;</span><br><span style="color: hsl(120, 100%, 40%);">+ /*Configure T(tiar) over VTY, seconds */</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer g_bsc_sccp_timer_iar := 15 * 60;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* global test case guard timer */</span><br><span> timer T_guard := 30.0;</span><br><span> </span><br><span>@@ -332,6 +337,8 @@</span><br><span> map(self:BSCVTY, system:BSCVTY);</span><br><span> f_vty_set_prompts(BSCVTY);</span><br><span> f_vty_transceive(BSCVTY, "enable");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_cs7_inst_0_cfg(BSCVTY, {"sccp-timer ias " & int2str(g_bsc_sccp_timer_ias),</span><br><span style="color: hsl(120, 100%, 40%);">+ "sccp-timer iar " & int2str(g_bsc_sccp_timer_iar)});</span><br><span> }</span><br><span> </span><br><span> /* global initialization function</span><br><span>@@ -1064,6 +1071,23 @@</span><br><span> setverdict(pass);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify T(iar) triggers and releases the channel */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_chan_rel_sccp_tiar_timeout() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var DchanTuple dt;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Set T(iar) in BSC low enough that it will trigger before other side</span><br><span style="color: hsl(120, 100%, 40%);">+ has time to keep alive with a T(ias). Keep recommended ratio of</span><br><span style="color: hsl(120, 100%, 40%);">+ T(iar) >= T(ias)*2 */</span><br><span style="color: hsl(120, 100%, 40%);">+ g_bsc_sccp_timer_ias := 2;</span><br><span style="color: hsl(120, 100%, 40%);">+ g_bsc_sccp_timer_iar := 5;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init(1);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ dt := f_est_dchan('23'O, 23, '00010203040506'O);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_expect_chan_rel(0, dt.rsl_chan_nr, expect_rll_rel_req := false);</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Test behavior if RSL EST IND for non-active channel */</span><br><span> testcase TC_rll_est_ind_inact_lchan() runs on test_CT {</span><br><span> timer T := 2.0;</span><br><span>@@ -3632,6 +3656,15 @@</span><br><span> f_vty_transceive(BSCVTY, "end");</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+private function f_cs7_inst_0_cfg(TELNETasp_PT pt, Commands cmds := {})</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_enter_cfg_cs7_inst(pt, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ for (var integer i := 0; i < sizeof(cmds); i := i+1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_transceive(pt, cmds[i]);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_transceive(pt, "end");</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> private function f_probe_for_handover(charstring log_label,</span><br><span> charstring log_descr,</span><br><span> charstring handover_vty_cmd,</span><br><span>@@ -4419,6 +4452,7 @@</span><br><span> execute( TC_chan_rel_hard_rlsd() );</span><br><span> execute( TC_chan_rel_hard_rlsd_ms_dead() );</span><br><span> execute( TC_chan_rel_a_reset() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_chan_rel_sccp_tiar_timeout() );</span><br><span> </span><br><span> execute( TC_outbound_connect() );</span><br><span> </span><br><span>diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml</span><br><span>index eb932ef..e266660 100644</span><br><span>--- a/bsc/expected-results.xml</span><br><span>+++ b/bsc/expected-results.xml</span><br><span>@@ -19,6 +19,7 @@</span><br><span> <testcase classname='BSC_Tests' name='TC_chan_rel_hard_rlsd' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests' name='TC_chan_rel_hard_rlsd_ms_dead' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests' name='TC_chan_rel_a_reset' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='BSC_Tests' name='TC_chan_rel_sccp_tiar_timeout' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests' name='TC_outbound_connect' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests' name='TC_assignment_cic_only' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests' name='TC_assignment_csd' time='MASKED'/></span><br><span>diff --git a/library/Osmocom_VTY_Functions.ttcn b/library/Osmocom_VTY_Functions.ttcn</span><br><span>index a1724e9..823d79f 100644</span><br><span>--- a/library/Osmocom_VTY_Functions.ttcn</span><br><span>+++ b/library/Osmocom_VTY_Functions.ttcn</span><br><span>@@ -102,6 +102,7 @@</span><br><span> type integer BtsTrxNr (0..255);</span><br><span> type integer BtsTimeslotNr (0..7);</span><br><span> type integer MscNr (0..255);</span><br><span style="color: hsl(120, 100%, 40%);">+ type integer Cs7Nr (0..255);</span><br><span> </span><br><span> type charstring BtsGprsMode ("none", "gprs", "egrps");</span><br><span> </span><br><span>@@ -135,6 +136,11 @@</span><br><span> f_vty_transceive(pt, "msc " & int2str(msc));</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ function f_vty_enter_cfg_cs7_inst(TELNETasp_PT pt, Cs7Nr cs7_inst := 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_enter_config(pt);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_transceive(pt, "cs7 instance " & int2str(cs7_inst));</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> type record of charstring rof_charstring;</span><br><span> function f_vty_config2(TELNETasp_PT pt, rof_charstring config_nodes, charstring cmd)</span><br><span> {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16798">change 16798</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16798"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic2724f62689b99c33e2e5c3a0c2fd022178a788c </div>
<div style="display:none"> Gerrit-Change-Number: 16798 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>