<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-netif/+/16779">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">stream.c: Improve logging during sock send()<br><br>Change-Id: Iff275c809ec2bb34f471d15bfdc92296566b76a7<br>---<br>M src/stream.c<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/stream.c b/src/stream.c</span><br><span>index 537fd28..fe3de2a 100644</span><br><span>--- a/src/stream.c</span><br><span>+++ b/src/stream.c</span><br><span>@@ -239,8 +239,6 @@</span><br><span>       struct llist_head *lh;</span><br><span>       int ret;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    LOGSCLI(cli, LOGL_DEBUG, "sending data\n");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>        if (llist_empty(&cli->tx_queue)) {</span><br><span>            cli->ofd.when &= ~BSC_FD_WRITE;</span><br><span>               return 0;</span><br><span>@@ -254,6 +252,8 @@</span><br><span>              return 0;</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ LOGSCLI(cli, LOGL_DEBUG, "sending %u bytes of data\n", msgb_length(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>        switch (cli->proto) {</span><br><span> #ifdef HAVE_LIBSCTP</span><br><span>      case IPPROTO_SCTP:</span><br><span>@@ -266,14 +266,14 @@</span><br><span> #endif</span><br><span>         case IPPROTO_TCP:</span><br><span>    default:</span><br><span style="color: hsl(0, 100%, 40%);">-                ret = send(cli->ofd.fd, msg->data, msg->len, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+             ret = send(cli->ofd.fd, msg->data, msgb_length(msg), 0);</span><br><span>               break;</span><br><span>       }</span><br><span>    if (ret < 0) {</span><br><span>            if (errno == EPIPE || errno == ENOTCONN) {</span><br><span>                   osmo_stream_cli_reconnect(cli);</span><br><span>              }</span><br><span style="color: hsl(0, 100%, 40%);">-               LOGSCLI(cli, LOGL_ERROR, "error to send\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                LOGSCLI(cli, LOGL_ERROR, "error %d to send\n", ret);</span><br><span>       }</span><br><span>    msgb_free(msg);</span><br><span>      return 0;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-netif/+/16779">change 16779</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-netif/+/16779"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-netif </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iff275c809ec2bb34f471d15bfdc92296566b76a7 </div>
<div style="display:none"> Gerrit-Change-Number: 16779 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>