<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/16817">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">dahdi: Don't use perror() directly, use osmocom logging instead<br><br>Change-Id: I287e10ee49a8ac26eef903568b29a3b2abf3b43e<br>---<br>M src/input/dahdi.c<br>1 file changed, 8 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/17/16817/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/input/dahdi.c b/src/input/dahdi.c</span><br><span>index 5da0a2d..4d01fe0 100644</span><br><span>--- a/src/input/dahdi.c</span><br><span>+++ b/src/input/dahdi.c</span><br><span>@@ -181,11 +181,13 @@</span><br><span>   if (ret == -1)</span><br><span>               handle_dahdi_exception(e1i_ts);</span><br><span>      else if (ret < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-          perror("read ");</span><br><span style="color: hsl(120, 100%, 40%);">+            LOGP(DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno));</span><br><span style="color: hsl(120, 100%, 40%);">+         return ret;</span><br><span>  }</span><br><span>    msgb_put(msg, ret - 2);</span><br><span>      if (ret <= 3) {</span><br><span style="color: hsl(0, 100%, 40%);">-              perror("read ");</span><br><span style="color: hsl(120, 100%, 40%);">+            LOGP(DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno));</span><br><span style="color: hsl(120, 100%, 40%);">+         return ret;</span><br><span>  }</span><br><span> </span><br><span>        return e1inp_rx_ts_lapd(e1i_ts, msg);</span><br><span>@@ -294,11 +296,13 @@</span><br><span>        if (ret == -1)</span><br><span>               handle_dahdi_exception(e1i_ts);</span><br><span>      else if (ret < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-          perror("read ");</span><br><span style="color: hsl(120, 100%, 40%);">+            LOGP(DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno));</span><br><span style="color: hsl(120, 100%, 40%);">+         return ret;</span><br><span>  }</span><br><span>    msgb_put(msg, ret - 2);</span><br><span>      if (ret <= 3) {</span><br><span style="color: hsl(0, 100%, 40%);">-              perror("read ");</span><br><span style="color: hsl(120, 100%, 40%);">+            LOGP(DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno));</span><br><span style="color: hsl(120, 100%, 40%);">+         return ret;</span><br><span>  }</span><br><span> </span><br><span>        return e1inp_rx_ts(e1i_ts, msg, 0, 0);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/16817">change 16817</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/16817"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I287e10ee49a8ac26eef903568b29a3b2abf3b43e </div>
<div style="display:none"> Gerrit-Change-Number: 16817 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>