<p>keith <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/16806">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  keith: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Use GSM411_RP_* and not GSM48_CC_*<br><br>d34ed5768cccab57e879bd32f38872d290c9ae89 introduced<br>comparison of GSM411_RP_CAUSE_MO_NUM_UNASSIGNED with<br>GSM48_CC_CAUSE_UNASSIGNED_NR<br><br>For consistency lets use the GSM411_RP constants<br>in SMS related code.<br><br>Change-Id: Ie54966560f66d2dcde905feb2eb19ef90406acd1<br>---<br>M src/libmsc/smpp_smsc.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/smpp_smsc.c b/src/libmsc/smpp_smsc.c</span><br><span>index 3bfb81a..df3c847 100644</span><br><span>--- a/src/libmsc/smpp_smsc.c</span><br><span>+++ b/src/libmsc/smpp_smsc.c</span><br><span>@@ -38,6 +38,7 @@</span><br><span> #include <osmocom/core/logging.h></span><br><span> #include <osmocom/core/write_queue.h></span><br><span> #include <osmocom/core/talloc.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/gsm/protocol/gsm_04_11.h></span><br><span> </span><br><span> #include "smpp_smsc.h"</span><br><span> </span><br><span>@@ -327,9 +328,9 @@</span><br><span> </span><br><span>       *pesme = NULL;</span><br><span>       if (acl)</span><br><span style="color: hsl(0, 100%, 40%);">-                return GSM48_CC_CAUSE_NETWORK_OOO;</span><br><span style="color: hsl(120, 100%, 40%);">+            return GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER;</span><br><span>  else</span><br><span style="color: hsl(0, 100%, 40%);">-            return GSM48_CC_CAUSE_UNASSIGNED_NR;</span><br><span style="color: hsl(120, 100%, 40%);">+          return GSM411_RP_CAUSE_MO_NUM_UNASSIGNED;</span><br><span> }</span><br><span> </span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/16806">change 16806</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/16806"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie54966560f66d2dcde905feb2eb19ef90406acd1 </div>
<div style="display:none"> Gerrit-Change-Number: 16806 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>