<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16696">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu: Check received IMSI suffix from PCUIF paging request<br><br>Change-Id: Ia11447fb71ea0b6a8fcce1a28e93cc166d22ef7a<br>---<br>M pcu/PCU_Tests_RAW.ttcn<br>1 file changed, 16 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/PCU_Tests_RAW.ttcn b/pcu/PCU_Tests_RAW.ttcn</span><br><span>index d0181a9..ab412c4 100644</span><br><span>--- a/pcu/PCU_Tests_RAW.ttcn</span><br><span>+++ b/pcu/PCU_Tests_RAW.ttcn</span><br><span>@@ -366,13 +366,19 @@</span><br><span> }</span><br><span> </span><br><span> /* Expect a Paging Request Type 1 from PCU on PCUIF on specified sapi.  */</span><br><span style="color: hsl(0, 100%, 40%);">-private function f_pcuif_rx_pch_pag_req1(out GsmRrMessage rr_pag_req1)</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_pcuif_rx_pch_pag_req1(out integer imsi_suff_rx, out GsmRrMessage rr_pag_req1)</span><br><span> runs on RAW_PCU_Test_CT {</span><br><span>         var PCUIF_Message pcu_msg;</span><br><span style="color: hsl(120, 100%, 40%);">+    var octetstring imsi_suff_octstr;</span><br><span>    var octetstring macblock;</span><br><span>    BTS.receive(tr_PCUIF_DATA_REQ(bts_nr := 0, trx_nr := 0, ts_nr := 0,</span><br><span>                                sapi := PCU_IF_SAPI_PCH)) -> value pcu_msg;</span><br><span style="color: hsl(0, 100%, 40%);">-    /* First 3 bytes contain paging group: */</span><br><span style="color: hsl(120, 100%, 40%);">+     /* First 3 bytes contain IMSI suffix to calculate paging group: */</span><br><span style="color: hsl(120, 100%, 40%);">+    imsi_suff_octstr := substr(pcu_msg.u.data_req.data, 0, 3);</span><br><span style="color: hsl(120, 100%, 40%);">+    imsi_suff_rx := str2int(oct2char(imsi_suff_octstr[0])) * 100 +</span><br><span style="color: hsl(120, 100%, 40%);">+                        str2int(oct2char(imsi_suff_octstr[1])) * 10 +</span><br><span style="color: hsl(120, 100%, 40%);">+                 str2int(oct2char(imsi_suff_octstr[2]));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    macblock := substr(pcu_msg.u.data_req.data, 3, pcu_msg.u.data_req.len - 3);</span><br><span>  rr_pag_req1 := dec_GsmRrMessage(macblock);</span><br><span>   if (not match(rr_pag_req1, tr_PAG_REQ1())) {</span><br><span>@@ -1385,7 +1391,9 @@</span><br><span> private function f_tc_paging_ps_from_sgsn(Nsvci bvci) runs on RAW_PCU_Test_CT {</span><br><span>      var GsmRrMessage rr_pag_req1;</span><br><span>        var OCT4 tlli := '00000001'O;</span><br><span style="color: hsl(0, 100%, 40%);">-   var hexstring imsi := f_gen_imsi(42);</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer imsi_suff_rx;</span><br><span style="color: hsl(120, 100%, 40%);">+     var integer imsi_suff_tx := 423;</span><br><span style="color: hsl(120, 100%, 40%);">+      var hexstring imsi := f_gen_imsi(imsi_suff_tx);</span><br><span> </span><br><span>  /* Initialize NS/BSSGP side */</span><br><span>       f_init_bssgp();</span><br><span>@@ -1401,7 +1409,11 @@</span><br><span>     BSSGP[0].send(ts_BSSGP_PS_PAGING_IMSI(bvci, imsi));</span><br><span> </span><br><span>      /* Receive it on BTS side towards MS */</span><br><span style="color: hsl(0, 100%, 40%);">- f_pcuif_rx_pch_pag_req1(rr_pag_req1);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_pcuif_rx_pch_pag_req1(imsi_suff_rx, rr_pag_req1);</span><br><span style="color: hsl(120, 100%, 40%);">+   if (imsi_suff_rx != imsi_suff_tx) {</span><br><span style="color: hsl(120, 100%, 40%);">+           setverdict(fail, "Wrong IMSI suffix: expected ", imsi_suff_tx, " but received ", imsi_suff_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+           mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span> </span><br><span>        setverdict(pass);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16696">change 16696</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16696"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia11447fb71ea0b6a8fcce1a28e93cc166d22ef7a </div>
<div style="display:none"> Gerrit-Change-Number: 16696 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>