<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/16805">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">WIP: firmware: sniffer: inbound USB handling<br><br>Change-Id: Ic953148600d82285281abcb573a07e2e9b8082a7<br>---<br>M firmware/libcommon/source/sniffer.c<br>1 file changed, 16 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/05/16805/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libcommon/source/sniffer.c b/firmware/libcommon/source/sniffer.c</span><br><span>index 78413ec..7fd9961 100644</span><br><span>--- a/firmware/libcommon/source/sniffer.c</span><br><span>+++ b/firmware/libcommon/source/sniffer.c</span><br><span>@@ -977,8 +977,22 @@</span><br><span> /* handle incoming message from USB OUT EP */</span><br><span> static void dispatch_usb_out(struct msgb *msg, const struct usb_if *usb_if)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-    /* currently we don't need any incoming data */</span><br><span style="color: hsl(0, 100%, 40%);">-     msgb_free(msg);</span><br><span style="color: hsl(120, 100%, 40%);">+       struct simtrace_msg_hdr *sh = (Struct simtrace_msg_hdr *) msg->l1h;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+      if (msg_length(msg) < sizeof(*sh)) {</span><br><span style="color: hsl(120, 100%, 40%);">+               usb_buf_free(msg);</span><br><span style="color: hsl(120, 100%, 40%);">+            return;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+     msg->l2h = msg->l1h + sizeof(*sh);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+    switch (sh->msg_class) {</span><br><span style="color: hsl(120, 100%, 40%);">+   case SIMTRACE_MSGC_GENERIC:</span><br><span style="color: hsl(120, 100%, 40%);">+           break;</span><br><span style="color: hsl(120, 100%, 40%);">+        default:</span><br><span style="color: hsl(120, 100%, 40%);">+              break;</span><br><span style="color: hsl(120, 100%, 40%);">+        }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   usb_buf_free(msg);</span><br><span> }</span><br><span> </span><br><span> static const struct usb_if sniffer_usb_if = {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/16805">change 16805</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/16805"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic953148600d82285281abcb573a07e2e9b8082a7 </div>
<div style="display:none"> Gerrit-Change-Number: 16805 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>