<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16767">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MSC: add test cases for concurrent MO/MT SS/USSD transactions<br><br>Both test cases make use of the existing functions:<br><br> - TC_multi_lu_and_mo_ussd: f_tc_lu_and_mo_ussd_single_request(),<br> - TC_multi_lu_and_mt_ussd: f_tc_lu_and_mt_ussd_notification(),<br><br>starting several (*) BSC_ConnHdlr components in parallel.<br><br>(*) The maximum amount is limited by 16 - this is as much<br> as both GSUP and SCTP emulation components can handle.<br><br>Change-Id: I2fb1c5d285163d5245d92fa24c197a5027ecbe6f<br>Related: OS#2931<br>---<br>M msc/MSC_Tests.ttcn<br>M msc/MSC_Tests_Iu.ttcn<br>M msc/expected-results.xml<br>3 files changed, 87 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index f7df81a..177c2f8 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -3695,6 +3695,44 @@</span><br><span> }</span><br><span> </span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify multiple concurrent MO SS/USSD transactions</span><br><span style="color: hsl(120, 100%, 40%);">+ * (one subscriber - one transaction) */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_multi_lu_and_mo_ussd() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlr vc_conn[16];</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer i;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i := 0; i < sizeof(vc_conn); i := i + 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn[i] := f_start_handler(refers(f_tc_lu_and_mo_ussd_single_request), 210 + i);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i := 0; i < sizeof(vc_conn); i := i + 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn[i].done;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify multiple concurrent MT SS/USSD transactions</span><br><span style="color: hsl(120, 100%, 40%);">+ * (one subscriber - one transaction) */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_multi_lu_and_mt_ussd() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlr vc_conn[16];</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer i;</span><br><span style="color: hsl(120, 100%, 40%);">+ var OCT4 sid;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i := 0; i < sizeof(vc_conn); i := i + 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ sid := '200001'O & int2oct(i, 1); /* All transactions must use different session ID */</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn[i] := f_start_handler_with_pars(refers(f_tc_lu_and_mt_ussd_notification),</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_pars(226 + i, gsup_sid := sid));</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i := 0; i < sizeof(vc_conn); i := i + 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn[i].done;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* A5/1 only permitted on network side; attempt an invalid CIPHER MODE COMPLETE with A5/3 which MSC should reject. */</span><br><span> private function f_tc_cipher_complete_with_invalid_cipher(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr {</span><br><span> pars.net.expect_auth := true;</span><br><span>@@ -5845,6 +5883,9 @@</span><br><span> execute( TC_proc_ss_paging_fail() );</span><br><span> execute( TC_proc_ss_abort() );</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_multi_lu_and_mo_ussd() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_multi_lu_and_mt_ussd() );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> execute( TC_cipher_complete_with_invalid_cipher() );</span><br><span> execute( TC_cipher_complete_1_without_cipher() );</span><br><span> execute( TC_cipher_complete_3_without_cipher() );</span><br><span>diff --git a/msc/MSC_Tests_Iu.ttcn b/msc/MSC_Tests_Iu.ttcn</span><br><span>index 586642b..b6b0983 100644</span><br><span>--- a/msc/MSC_Tests_Iu.ttcn</span><br><span>+++ b/msc/MSC_Tests_Iu.ttcn</span><br><span>@@ -462,6 +462,45 @@</span><br><span> vc_conn.done;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify multiple concurrent MO SS/USSD transactions</span><br><span style="color: hsl(120, 100%, 40%);">+ * (one subscriber - one transaction) */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_iu_multi_lu_and_mo_ussd() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlr vc_conn[8];</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlrPars pars;</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer i;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init(3);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i := 0; i < sizeof(vc_conn); i := i + 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ pars := f_init_pars(1100 + i, ran_idx := 2, ran_is_geran := false);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn[i] := f_start_handler_with_pars(refers(f_tc_lu_and_mo_ussd_single_request), pars);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i := 0; i < sizeof(vc_conn); i := i + 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn[i].done;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify multiple concurrent MT SS/USSD transactions</span><br><span style="color: hsl(120, 100%, 40%);">+ * (one subscriber - one transaction) */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_iu_multi_lu_and_mt_ussd() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlr vc_conn[8];</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlrPars pars;</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer i;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init(3);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i := 0; i < sizeof(vc_conn); i := i + 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ pars := f_init_pars(1110 + i, ran_idx := 2, ran_is_geran := false,</span><br><span style="color: hsl(120, 100%, 40%);">+ gsup_sid := '200001'O & int2oct(i, 1));</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn[i] := f_start_handler_with_pars(refers(f_tc_lu_and_mt_ussd_notification), pars);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i := 0; i < sizeof(vc_conn); i := i + 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn[i].done;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> testcase TC_iu_lu_with_invalid_mcc_mnc() runs on MTC_CT {</span><br><span> var BSC_ConnHdlr vc_conn;</span><br><span> f_init(3);</span><br><span>@@ -523,6 +562,9 @@</span><br><span> execute( TC_iu_proc_ss_paging_fail() );</span><br><span> execute( TC_iu_proc_ss_abort() );</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_iu_multi_lu_and_mo_ussd() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_iu_multi_lu_and_mt_ussd() );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> execute( TC_iu_lu_with_invalid_mcc_mnc() );</span><br><span> </span><br><span> /* TODO: Iu + SGsAP related tests, e.g. paging on IuCS */</span><br><span>diff --git a/msc/expected-results.xml b/msc/expected-results.xml</span><br><span>index a7b7142..074eeb1 100644</span><br><span>--- a/msc/expected-results.xml</span><br><span>+++ b/msc/expected-results.xml</span><br><span>@@ -73,6 +73,8 @@</span><br><span> <testcase classname='MSC_Tests' name='TC_proc_ss_for_unknown_session' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_proc_ss_paging_fail' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_proc_ss_abort' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='MSC_Tests' name='TC_multi_lu_and_mo_ussd' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='MSC_Tests' name='TC_multi_lu_and_mt_ussd' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_cipher_complete_with_invalid_cipher' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_cipher_complete_1_without_cipher' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_cipher_complete_3_without_cipher' time='MASKED'/></span><br><span>@@ -212,6 +214,8 @@</span><br><span> <testcase classname='MSC_Tests_Iu' name='TC_iu_proc_ss_for_unknown_session' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests_Iu' name='TC_iu_proc_ss_paging_fail' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests_Iu' name='TC_iu_proc_ss_abort' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='MSC_Tests_Iu' name='TC_iu_multi_lu_and_mo_ussd' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='MSC_Tests_Iu' name='TC_iu_multi_lu_and_mt_ussd' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests_Iu' name='TC_iu_lu_with_invalid_mcc_mnc' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests_Iu' name='TC_mo_cc_iu_release' time='MASKED'/></span><br><span> </testsuite></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16767">change 16767</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16767"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2fb1c5d285163d5245d92fa24c197a5027ecbe6f </div>
<div style="display:none"> Gerrit-Change-Number: 16767 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>