<p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16204">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16204/18/contrib/dgsm/esme_dgsm.py">File contrib/dgsm/esme_dgsm.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16204/18/contrib/dgsm/esme_dgsm.py@4">Patch Set #18, Line 4:</a> <code style="font-family:monospace,monospace">Copyright 2019 sysmocom s.f.m.c GmbH <info@sysmocom.de></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">If it's possible legally, as the author of the file this was based on, i'd give explicit permission […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">As discussed in IRC: changed to MIT.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16204/18/contrib/dgsm/esme_dgsm.py@42">Patch Set #18, Line 42:</a> <code style="font-family:monospace,monospace"> logging.info('PDU is not a DeliverSM. Is OsmoMSC configured properly?')</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">You may log a lot of Alert Notifications (1 for each LUR) at log level info. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Message changed to "PDU is not a DeliverSM, ignoring"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16204/18/contrib/dgsm/esme_dgsm.py@48">Patch Set #18, Line 48:</a> <code style="font-family:monospace,monospace"> " example, dropping message.")</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">OOoops. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Sorry to hear that there's a bug in RCCN :\</p><p style="white-space: pre-wrap; word-wrap: break-word;">Thanks, I've deleted the lines.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16204/18/contrib/dgsm/esme_dgsm.py@87">Patch Set #18, Line 87:</a> <code style="font-family:monospace,monospace"> registered_delivery=False,</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">OK, this is a P.O.C. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Fixed.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16204">change 16204</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/16204"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I26e8dd8d9a08187fccb3e74ee91366bc24f6c608 </div>
<div style="display:none"> Gerrit-Change-Number: 16204 </div>
<div style="display:none"> Gerrit-PatchSet: 22 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 10 Jan 2020 14:43:40 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Comment-In-Reply-To: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Comment-In-Reply-To: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>