<p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16459">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16459/3/include/osmocom/gsupclient/gsup_peer_id.h">File include/osmocom/gsupclient/gsup_peer_id.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16459/3/include/osmocom/gsupclient/gsup_peer_id.h@30">Patch Set #3, Line 30:</a> <code style="font-family:monospace,monospace">struct osmo_ipa_name {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">So it is added in previous commit, then in this one it's moved to a new header while adding a new os […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">for hysterical raisins. I kept this separate because I was unsure whether we would keep this, in the end we could squash the two commits...</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16459/3/include/osmocom/gsupclient/gsup_req.h">File include/osmocom/gsupclient/gsup_req.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16459/3/include/osmocom/gsupclient/gsup_req.h@29">Patch Set #3, Line 29:</a> <code style="font-family:monospace,monospace">              (req) ? osmo_gsup_peer_id_to_str(&(req)->source_name) : "NULL", \</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">it shouldn't be called source_name anymore, but source_id.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">you're probably right.</p><p style="white-space: pre-wrap; word-wrap: break-word;">let's figure out what we have...<br>"ipa-name" in the vty config, "vlr_number" in the hlr.sql, osmo_gsup_peer_id added here; total mixup.<br>Would be nice if we had some sort of a plan for the future. a utopia to converge towards?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16459">change 16459</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/16459"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ide9dcdca283ab989240cfc6e53e9211862a199c5 </div>
<div style="display:none"> Gerrit-Change-Number: 16459 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 09 Jan 2020 16:43:34 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>