<p>Patch set 14:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16257">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16257/14/include/osmocom/hlr/mslookup_server.h">File include/osmocom/hlr/mslookup_server.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16257/14/include/osmocom/hlr/mslookup_server.h@22">Patch Set #14, Line 22:</a> <code style="font-family:monospace,monospace">#include <osmocom/gsupclient/gsup_peer_id.h></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">So no change in the header file but 2 new includes are added? That looks wrong...</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16257/14/include/osmocom/hlr/mslookup_server_mdns.h">File include/osmocom/hlr/mslookup_server_mdns.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16257/14/include/osmocom/hlr/mslookup_server_mdns.h@22">Patch Set #14, Line 22:</a> <code style="font-family:monospace,monospace">#include <stdbool.h></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">bool is not used here, you can drop it.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16257/14/src/dgsm_vty.c">File src/dgsm_vty.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16257/14/src/dgsm_vty.c@177">Patch Set #14, Line 177:</a> <code style="font-family:monospace,monospace">      "service NAME at IP <1-65535>",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">let's drop that "at" here, I don't see it bringing anything good rather than having to type more.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16257/14/src/dgsm_vty.c@236">Patch Set #14, Line 236:</a> <code style="font-family:monospace,monospace">      "no service NAME at IP <1-65535>",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">remove "at".</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/16257">change 16257</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/16257"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5cae6459090588b4dd292be90a5e8903432669d2 </div>
<div style="display:none"> Gerrit-Change-Number: 16257 </div>
<div style="display:none"> Gerrit-PatchSet: 14 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 08 Jan 2020 13:49:08 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>