<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/16757">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">add/clean big-endian packed structs (struct_endianess.py)<br><br>Change-Id: I09c56f59631828ad219a5edd7d95cac8df462c84<br>---<br>M src/e1_input.c<br>1 file changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/57/16757/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/e1_input.c b/src/e1_input.c</span><br><span>index eb973ef..9e2f7b0 100644</span><br><span>--- a/src/e1_input.c</span><br><span>+++ b/src/e1_input.c</span><br><span>@@ -42,6 +42,7 @@</span><br><span> #include <osmocom/core/rate_ctr.h></span><br><span> #include <osmocom/core/logging.h></span><br><span> #include <osmocom/core/signal.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/endian.h></span><br><span> #include <osmocom/abis/e1_input.h></span><br><span> </span><br><span> #define NUM_E1_TS       32</span><br><span>@@ -115,12 +116,19 @@</span><br><span> } __attribute__((packed));</span><br><span> </span><br><span> struct lapd_header {</span><br><span style="color: hsl(120, 100%, 40%);">+#if OSMO_IS_LITTLE_ENDIAN</span><br><span>      uint8_t ea1 : 1;</span><br><span>     uint8_t cr : 1;</span><br><span>      uint8_t sapi : 6;</span><br><span>    uint8_t ea2 : 1;</span><br><span>     uint8_t tei : 7;</span><br><span>     uint8_t control_foo; /* fake UM's ... */</span><br><span style="color: hsl(120, 100%, 40%);">+#elif OSMO_IS_BIG_ENDIAN</span><br><span style="color: hsl(120, 100%, 40%);">+/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */</span><br><span style="color: hsl(120, 100%, 40%);">+      uint8_t sapi:6, cr:1, ea1:1;</span><br><span style="color: hsl(120, 100%, 40%);">+  uint8_t tei:7, ea2:1;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t control_foo;</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> } __attribute__((packed));</span><br><span> </span><br><span> osmo_static_assert(offsetof(struct fake_linux_lapd_header, hatype) == 2,    hatype_offset);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/16757">change 16757</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/16757"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I09c56f59631828ad219a5edd7d95cac8df462c84 </div>
<div style="display:none"> Gerrit-Change-Number: 16757 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>