<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/16744">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix nullpointer: in gsm48_rx_gmm_ra_upd_req()<br><br>This caused frequent crashes at 36c3. The "proper" fix is probably elsewhere<br>(lynxis mentions an unfinished patch), but at least this prevented some crashes<br>during active operation.<br><br>Change-Id: Ifde15dc4151d84748f0e67b32c9c260cb2d9d8fc<br>---<br>M src/sgsn/gprs_gmm.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/44/16744/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c</span><br><span>index f62d0d1..d340005 100644</span><br><span>--- a/src/sgsn/gprs_gmm.c</span><br><span>+++ b/src/sgsn/gprs_gmm.c</span><br><span>@@ -1642,7 +1642,7 @@</span><br><span>    rate_ctr_inc(&mmctx->ctrg->ctr[GMM_CTR_PKTS_SIG_IN]);</span><br><span> </span><br><span>  /* Update the MM context with the new RA-ID */</span><br><span style="color: hsl(0, 100%, 40%);">-  if (mmctx->ran_type == MM_CTX_T_GERAN_Gb) {</span><br><span style="color: hsl(120, 100%, 40%);">+        if (mmctx->ran_type == MM_CTX_T_GERAN_Gb && msgb_bcid(msg)) {</span><br><span>             bssgp_parse_cell_id(&mmctx->ra, msgb_bcid(msg));</span><br><span>              /* Update the MM context with the new (i.e. foreign) TLLI */</span><br><span>                 mmctx->gb.tlli = msgb_tlli(msg);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/16744">change 16744</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/16744"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifde15dc4151d84748f0e67b32c9c260cb2d9d8fc </div>
<div style="display:none"> Gerrit-Change-Number: 16744 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>