<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16729">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ggsn: Drop unneeded mp_enable_conn_timeout_test<br><br>Latest osmo-ggsn release is 1.75.0, so this param is not needed at all.<br><br>Change-Id: Ie1c3cde2a01e8ea49aadcb1f7384995cb68039cb<br>---<br>M ggsn_tests/GGSN_Tests.ttcn<br>1 file changed, 2 insertions(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/16729/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn</span><br><span>index 44dba4a..40506df 100644</span><br><span>--- a/ggsn_tests/GGSN_Tests.ttcn</span><br><span>+++ b/ggsn_tests/GGSN_Tests.ttcn</span><br><span>@@ -64,13 +64,6 @@</span><br><span>           * The tests expect to be able to send ping packets between any two simulated MS within the same</span><br><span>              * address range. This requires IP forwarding to be enabled on the corresponding tun interfaces.</span><br><span>              */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-             /*</span><br><span style="color: hsl(0, 100%, 40%);">-               * Whether ggsn supports "(no) echo-interval" VTY command</span><br><span style="color: hsl(0, 100%, 40%);">-              * (osmo-ggsn.git Id2c84165dc59dff495106758146a701ca488834f).</span><br><span style="color: hsl(0, 100%, 40%);">-            * This option can be dropped after osmo-ggsn release > 1.4.0 exists.</span><br><span style="color: hsl(0, 100%, 40%);">-                 */</span><br><span style="color: hsl(0, 100%, 40%);">-             boolean m_ggsn_supports_echo_interval := true;</span><br><span>       }</span><br><span> </span><br><span>        type set PdpContext {</span><br><span>@@ -203,9 +196,7 @@</span><br><span> </span><br><span>              f_init_vty();</span><br><span>                f_vty_set_gpdu_txseq(use_gtpu_txseq);</span><br><span style="color: hsl(0, 100%, 40%);">-           if (m_ggsn_supports_echo_interval) {</span><br><span style="color: hsl(0, 100%, 40%);">-                    f_vty_enable_echo_interval(g_use_echo);</span><br><span style="color: hsl(0, 100%, 40%);">-         }</span><br><span style="color: hsl(120, 100%, 40%);">+             f_vty_enable_echo_interval(g_use_echo);</span><br><span>      }</span><br><span> </span><br><span>        /* Altstep implementing responses to any incoming echo requests */</span><br><span>@@ -1506,8 +1497,6 @@</span><br><span>           execute(TC_pdp_act2_recovery());</span><br><span>             execute(TC_act_deact_retrans_duplicate());</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-          if (m_ggsn_supports_echo_interval) {</span><br><span style="color: hsl(0, 100%, 40%);">-                    execute(TC_pdp_act_restart_ctr_echo());</span><br><span style="color: hsl(0, 100%, 40%);">-         }</span><br><span style="color: hsl(120, 100%, 40%);">+             execute(TC_pdp_act_restart_ctr_echo());</span><br><span>      }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16729">change 16729</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16729"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie1c3cde2a01e8ea49aadcb1f7384995cb68039cb </div>
<div style="display:none"> Gerrit-Change-Number: 16729 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>