<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/16233">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">l1sap.c: ensure ms power control loop is running<br><br>When a bad SACCH frame is received the processing of the frame is ended<br>early and lchan_ms_pwr_ctrl() is not called. This means that the power<br>control loop does not get informed about a situation where the signal<br>level is very weak and increasing the ms power would make sense. In<br>order to ensure that the power control keeps working on lost SACCH<br>frames, lets call lchan_ms_pwr_ctrl() with the current RSSI and the<br>requested (BSC) power setting.<br><br>Related: OS#4281<br>Change-Id: I4fb85754b1a69376b02da7f4b175c6e8ec9cc35c<br>---<br>M src/common/l1sap.c<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/l1sap.c b/src/common/l1sap.c</span><br><span>index 4930257..b73de29 100644</span><br><span>--- a/src/common/l1sap.c</span><br><span>+++ b/src/common/l1sap.c</span><br><span>@@ -1244,10 +1244,12 @@</span><br><span>                        * This is a fallback method. The report will also</span><br><span>                    * lack the measurement report from the MS side. See</span><br><span>                          * also rsl.c:lapdm_rll_tx_cb() */</span><br><span style="color: hsl(120, 100%, 40%);">+                    LOGPGT(DL1P, LOGL_INFO, &g_time, "Lost SACCH block, faking meas reports and ms pwr\n");</span><br><span>                        le = &lchan->lapdm_ch.lapdm_acch;</span><br><span>                     rsl_tx_meas_res(lchan, NULL, 0, le);</span><br><span> </span><br><span>                     radio_link_timeout(lchan, 1);</span><br><span style="color: hsl(120, 100%, 40%);">+                 lchan_ms_pwr_ctrl(lchan, lchan->ms_power_ctrl.current, data_ind->rssi);</span><br><span>                }</span><br><span>            return -EINVAL;</span><br><span>      }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/16233">change 16233</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/16233"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4fb85754b1a69376b02da7f4b175c6e8ec9cc35c </div>
<div style="display:none"> Gerrit-Change-Number: 16233 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>