<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16727">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mgw: Drop unneeded mp_enable_conn_timeout_test<br><br>Latest osmo-mgw release is 1.7.0, so this param is not needed at all.<br>Furthermore, the config can be moved to .cfg.<br><br>Change-Id: I537c0f5fd6f9e18e111c773c0e42e5f1120ce2f4<br>---<br>M mgw/MGCP_Test.ttcn<br>M mgw/osmo-mgw.cfg<br>2 files changed, 2 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/27/16727/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn</span><br><span>index b46b178..77eed4b 100644</span><br><span>--- a/mgw/MGCP_Test.ttcn</span><br><span>+++ b/mgw/MGCP_Test.ttcn</span><br><span>@@ -69,10 +69,6 @@</span><br><span>                 charstring mp_remote_ip := "127.0.0.1";</span><br><span>            PortNumber mp_local_rtp_port_base := 10000;</span><br><span>          PortNumber mp_local_osmux_port := 1985;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-         /* Whether to enable conn-timeout tests. Can be dropped completely and enabled unconditionally once new</span><br><span style="color: hsl(0, 100%, 40%);">-          * version of osmo-mgw is released (current version: 1.5.0) */</span><br><span style="color: hsl(0, 100%, 40%);">-          boolean mp_enable_conn_timeout_test := true;</span><br><span>         }</span><br><span> </span><br><span>        private function f_vty_enable_osmux(boolean osmux_on) runs on dummy_CT {</span><br><span>@@ -95,9 +91,6 @@</span><br><span>                 f_vty_transceive(MGWVTY, "enable");</span><br><span> </span><br><span>            f_vty_enable_osmux(osmux_on);</span><br><span style="color: hsl(0, 100%, 40%);">-           if (mp_enable_conn_timeout_test) {</span><br><span style="color: hsl(0, 100%, 40%);">-                      f_vty_config(MGWVTY, "mgcp", "conn-timeout 0");</span><br><span style="color: hsl(0, 100%, 40%);">-             }</span><br><span>    }</span><br><span> </span><br><span>        private function f_rtpem_init(inout RTP_Emulation_CT comp_ref, integer i)</span><br><span>@@ -2199,8 +2192,6 @@</span><br><span>            execute(TC_amr_oa_oa_rtp_conversion());</span><br><span>              execute(TC_amr_bwe_bwe_rtp_conversion());</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-           if (mp_enable_conn_timeout_test) {</span><br><span style="color: hsl(0, 100%, 40%);">-                      execute(TC_conn_timeout());</span><br><span style="color: hsl(0, 100%, 40%);">-             }</span><br><span style="color: hsl(120, 100%, 40%);">+             execute(TC_conn_timeout());</span><br><span>  }</span><br><span> }</span><br><span>diff --git a/mgw/osmo-mgw.cfg b/mgw/osmo-mgw.cfg</span><br><span>index b27a50c..edc8190 100644</span><br><span>--- a/mgw/osmo-mgw.cfg</span><br><span>+++ b/mgw/osmo-mgw.cfg</span><br><span>@@ -31,6 +31,7 @@</span><br><span>   sdp audio-payload name GSM</span><br><span>   sdp audio-payload send-ptime</span><br><span>   sdp audio-payload send-name</span><br><span style="color: hsl(120, 100%, 40%);">+  conn-timeout 0</span><br><span>   loop 0</span><br><span>   number endpoints 31</span><br><span>   allow-transcoding</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16727">change 16727</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16727"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I537c0f5fd6f9e18e111c773c0e42e5f1120ce2f4 </div>
<div style="display:none"> Gerrit-Change-Number: 16727 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>