<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/16697">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">logging_vty.c: Avoid acquiring log tgt lock in logging level cmd when not needed<br><br>Change-Id: Ia6780221174070cee408625e24513f2c11cc9dfc<br>---<br>M src/vty/logging_vty.c<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/97/16697/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c</span><br><span>index 6d908d9..c51b437 100644</span><br><span>--- a/src/vty/logging_vty.c</span><br><span>+++ b/src/vty/logging_vty.c</span><br><span>@@ -351,18 +351,18 @@</span><br><span>     int category = log_parse_category(argv[0]);</span><br><span>  int level = log_parse_level(argv[1]);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       ACQUIRE_VTY_LOG_TGT_WITH_LOCK(vty, tgt);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>     if (level < 0) {</span><br><span>          vty_out(vty, "Invalid level `%s'%s", argv[1], VTY_NEWLINE);</span><br><span style="color: hsl(0, 100%, 40%);">-               RET_WITH_UNLOCK(CMD_WARNING);</span><br><span style="color: hsl(120, 100%, 40%);">+         return CMD_WARNING;</span><br><span>  }</span><br><span> </span><br><span>        if (category < 0) {</span><br><span>               vty_out(vty, "Invalid category `%s'%s", argv[0], VTY_NEWLINE);</span><br><span style="color: hsl(0, 100%, 40%);">-            RET_WITH_UNLOCK(CMD_WARNING);</span><br><span style="color: hsl(120, 100%, 40%);">+         return CMD_WARNING;</span><br><span>  }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ ACQUIRE_VTY_LOG_TGT_WITH_LOCK(vty, tgt);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   tgt->categories[category].enabled = 1;</span><br><span>    tgt->categories[category].loglevel = level;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/16697">change 16697</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/16697"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia6780221174070cee408625e24513f2c11cc9dfc </div>
<div style="display:none"> Gerrit-Change-Number: 16697 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>