<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16694">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/RLCMAC_CSN1_Types.ttcn: fix ps / cs selection in PageInfo union<br><br>Change-Id: I40c2a3c38799a625836e4c28f476524c92077b83<br>---<br>M library/RLCMAC_CSN1_Types.ttcn<br>M pcu/PCU_Tests_RAW.ttcn<br>2 files changed, 6 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/94/16694/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/RLCMAC_CSN1_Types.ttcn b/library/RLCMAC_CSN1_Types.ttcn</span><br><span>index 11df29d..321049c 100644</span><br><span>--- a/library/RLCMAC_CSN1_Types.ttcn</span><br><span>+++ b/library/RLCMAC_CSN1_Types.ttcn</span><br><span>@@ -230,6 +230,8 @@</span><br><span>     type union PageInfo {</span><br><span>                PageInfoPs              ps,</span><br><span>          PageInfoCs              cs</span><br><span style="color: hsl(120, 100%, 40%);">+    } with {</span><br><span style="color: hsl(120, 100%, 40%);">+              variant "TAG(ps, presence = '0'B; cs, presence = '1'B)"</span><br><span>    };</span><br><span>   type record PacketPagingReq {</span><br><span>                PageMode                page_mode,</span><br><span>diff --git a/pcu/PCU_Tests_RAW.ttcn b/pcu/PCU_Tests_RAW.ttcn</span><br><span>index d19093c..cd13ff5 100644</span><br><span>--- a/pcu/PCU_Tests_RAW.ttcn</span><br><span>+++ b/pcu/PCU_Tests_RAW.ttcn</span><br><span>@@ -1299,10 +1299,8 @@</span><br><span> </span><br><span>         /* Receive it on BTS side towards MS */</span><br><span>      f_rx_rlcmac_dl_block_exp_pkt_pag_req(dl_block);</span><br><span style="color: hsl(0, 100%, 40%);">- /* FIXME: we must use .ps. here instead of .cs. (the one actually sent)</span><br><span style="color: hsl(0, 100%, 40%);">-    because TTCN3 counts length up to octet boundary and thinks it's a</span><br><span style="color: hsl(0, 100%, 40%);">-          PageInfoPs: */</span><br><span style="color: hsl(0, 100%, 40%);">-       mi_res := dl_block.ctrl.payload.u.paging.repeated_pageinfo.ps.mobile_identity;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+      mi_res := dl_block.ctrl.payload.u.paging.repeated_pageinfo.cs.mobile_identity;</span><br><span>       if (oct2int(substr(mi_enc_lv, 0, 1)) != mi_res.len) {</span><br><span>                /* TODO: Verify MI contents encoded match */</span><br><span>                 setverdict(fail, "Mobile Identity not matching (imsi=", imsi, ")");</span><br><span>@@ -1351,10 +1349,8 @@</span><br><span>     /* Receive it on BTS side towards MS */</span><br><span>      f_rx_rlcmac_dl_block_exp_pkt_pag_req(dl_block);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     /* FIXME: we must use .ps. here instead of .cs. (the one actually sent)</span><br><span style="color: hsl(0, 100%, 40%);">-    because TTCN3 counts length up to octet boundary and thinks it's a</span><br><span style="color: hsl(0, 100%, 40%);">-          PageInfoPs: */</span><br><span style="color: hsl(0, 100%, 40%);">-       mi_res := dl_block.ctrl.payload.u.paging.repeated_pageinfo.ps.mobile_identity;</span><br><span style="color: hsl(120, 100%, 40%);">+        /* FIXME: actually match the identity */</span><br><span style="color: hsl(120, 100%, 40%);">+      mi_res := dl_block.ctrl.payload.u.paging.repeated_pageinfo.cs.mobile_identity;</span><br><span>       setverdict(pass);</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16694">change 16694</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16694"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I40c2a3c38799a625836e4c28f476524c92077b83 </div>
<div style="display:none"> Gerrit-Change-Number: 16694 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>