<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/16690">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Fixup: Fix automated tests<br><br>The Change I12e6b46787efb39c5745f4e7f3cdcca9209881b8 was not as<br>effective as expected. Diff is used wrongly so that no lines are<br>compared. Lets fix this<br><br>Change-Id: I1601d8a2b3e1c07fe1eba375ea8deae3d50bbef0<br>---<br>M tests/pysim-test.sh<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/90/16690/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/pysim-test.sh b/tests/pysim-test.sh</span><br><span>index c3e1747..0d469c9 100755</span><br><span>--- a/tests/pysim-test.sh</span><br><span>+++ b/tests/pysim-test.sh</span><br><span>@@ -82,7 +82,9 @@</span><br><span>     # pysim would print the device number of the reader and we do not</span><br><span>     # want the test to fail just because the card is put into a different</span><br><span>     # reader device.</span><br><span style="color: hsl(0, 100%, 40%);">-    CARD_DIFF=$(diff + 1 $TEMPFILE ./$CARD_NAME.ok)</span><br><span style="color: hsl(120, 100%, 40%);">+    tail -n +2 $CARD_NAME.ok > $CARD_NAME.ok.tmp</span><br><span style="color: hsl(120, 100%, 40%);">+    tail -n +2 $TEMPFILE > $CARD_NAME.chk.tmp</span><br><span style="color: hsl(120, 100%, 40%);">+    CARD_DIFF=$(diff $CARD_NAME.chk.tmp $CARD_NAME.ok.tmp)</span><br><span>     set -e</span><br><span> </span><br><span>     if [ "$CARD_DIFF" != "" ]; then</span><br><span>@@ -95,13 +97,14 @@</span><br><span>        echo "------------8<------------"</span><br><span>       cat $TEMPFILE</span><br><span>        echo "------------8<------------"</span><br><span style="color: hsl(120, 100%, 40%);">+        rm *.tmp</span><br><span>     exit 1</span><br><span>     fi</span><br><span> </span><br><span>     inc_card_list $CARD_NAME</span><br><span> </span><br><span>     echo "Card contents match the test data -- success!"</span><br><span style="color: hsl(0, 100%, 40%);">-    rm $TEMPFILE</span><br><span style="color: hsl(120, 100%, 40%);">+    rm *.tmp</span><br><span> }</span><br><span> </span><br><span> # Read out the card using pysim-read and store the result as .ok file. This</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/16690">change 16690</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/16690"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1601d8a2b3e1c07fe1eba375ea8deae3d50bbef0 </div>
<div style="display:none"> Gerrit-Change-Number: 16690 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>