<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/16630">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[lib] apdu_dispatch: Use DLGLOBAL and don't printf() directly<br><br>Change-Id: I2f3ec49d34b6806e13af185fb629cabc486891fb<br>---<br>M host/lib/apdu_dispatch.c<br>1 file changed, 7 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/host/lib/apdu_dispatch.c b/host/lib/apdu_dispatch.c</span><br><span>index 62a75aa..835b8bc 100644</span><br><span>--- a/host/lib/apdu_dispatch.c</span><br><span>+++ b/host/lib/apdu_dispatch.c</span><br><span>@@ -1,6 +1,6 @@</span><br><span> /* apdu_dispatch - State machine to determine Rx/Tx phases of APDU</span><br><span>  *</span><br><span style="color: hsl(0, 100%, 40%);">- * (C) 2016 by Harald Welte <hwelte@hmw-consulting.de></span><br><span style="color: hsl(120, 100%, 40%);">+ * (C) 2016-2019 by Harald Welte <hwelte@hmw-consulting.de></span><br><span>  *</span><br><span>  * This program is free software; you can redistribute it and/or</span><br><span>  * modify it under the terms of the GNU General Public License</span><br><span>@@ -24,6 +24,7 @@</span><br><span> #include <errno.h></span><br><span> </span><br><span> #include <osmocom/core/utils.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/logging.h></span><br><span> #include <osmocom/sim/sim.h></span><br><span> #include <osmocom/sim/class_tables.h></span><br><span> </span><br><span>@@ -105,7 +106,7 @@</span><br><span>                      break;</span><br><span>               case 0:</span><br><span>              default:</span><br><span style="color: hsl(0, 100%, 40%);">-                        fprintf(stderr, "Unknown APDU case %d\n", ac->apdu_case);</span><br><span style="color: hsl(120, 100%, 40%);">+                        LOGP(DLGLOBAL, LOGL_ERROR, "Unknown APDU case %d\n", ac->apdu_case);</span><br><span>                    return -1;</span><br><span>           }</span><br><span>    } else {</span><br><span>@@ -124,8 +125,8 @@</span><br><span>                       ac->lc.cur += cpy_len;</span><br><span>                    break;</span><br><span>               default:</span><br><span style="color: hsl(0, 100%, 40%);">-                        fprintf(stderr, "Unknown APDU case %d\n", ac->apdu_case);</span><br><span style="color: hsl(0, 100%, 40%);">-                  break;</span><br><span style="color: hsl(120, 100%, 40%);">+                        LOGP(DLGLOBAL, LOGL_ERROR, "Unknown APDU case %d\n", ac->apdu_case);</span><br><span style="color: hsl(120, 100%, 40%);">+                     return -1;</span><br><span>           }</span><br><span>    }</span><br><span> </span><br><span>@@ -163,8 +164,8 @@</span><br><span>          break;</span><br><span>       case 0:</span><br><span>      default:</span><br><span style="color: hsl(0, 100%, 40%);">-                fprintf(stderr, "Unknown APDU case %d\n", ac->apdu_case);</span><br><span style="color: hsl(0, 100%, 40%);">-          break;</span><br><span style="color: hsl(120, 100%, 40%);">+                LOGP(DLGLOBAL, LOGL_ERROR, "Unknown APDU case %d\n", ac->apdu_case);</span><br><span style="color: hsl(120, 100%, 40%);">+             return -1;</span><br><span>   }</span><br><span> </span><br><span>        dump_apdu_ctx(ac);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/16630">change 16630</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/16630"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2f3ec49d34b6806e13af185fb629cabc486891fb </div>
<div style="display:none"> Gerrit-Change-Number: 16630 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>