<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/16608">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_bssgp: Work around gcc-9 claiming "error=stringop-overflow"<br><br>gcc-9.2.1 issues the following errror when compiling with -Werror:<br><br>In function ‘tl16v_put’,<br>    inlined from ‘tvlv_put’ at ../../include/osmocom/gsm/tlv.h:156:9,<br>    inlined from ‘tvlv_put’ at ../../include/osmocom/gsm/tlv.h:147:24,<br>    inlined from ‘msgb_tvlv_put’ at ../../include/osmocom/gsm/tlv.h:223:9,<br>    inlined from ‘bssgp_tx_paging’ at gprs_bssgp.c:1250:2:<br>../../include/osmocom/gsm/tlv.h:131:2: error: ‘memcpy’ reading between 128 and 65535 bytes from a region of size 9 [-Werror=stringop-overflow=]<br>  131 |  memcpy(buf, val, len);<br>      |  ^~~~~~~~~~~~~~~~~~~~~<br><br>Unfortunately I've not been able to work around it with some nice GCC<br>  #pragma GCC diagnostic ignored "-Wstringop-overflow"<br><br>Change-Id: I22a0c399c6c00eaf87277002096a82844c9e198e<br>---<br>M src/gb/gprs_bssgp.c<br>M src/gb/gprs_bssgp_bss.c<br>2 files changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c</span><br><span>index 896f1c5..38794c2 100644</span><br><span>--- a/src/gb/gprs_bssgp.c</span><br><span>+++ b/src/gb/gprs_bssgp.c</span><br><span>@@ -1178,6 +1178,7 @@</span><br><span> #pragma GCC diagnostic push</span><br><span> #pragma GCC diagnostic ignored "-Warray-bounds"</span><br><span>          int imsi_len = gsm48_generate_mid_from_imsi(mi, dup->imsi);</span><br><span style="color: hsl(120, 100%, 40%);">+                OSMO_ASSERT(imsi_len <= GSM48_MID_MAX_SIZE);</span><br><span>              if (imsi_len > 2)</span><br><span>                         msgb_tvlv_push(msg, BSSGP_IE_IMSI,</span><br><span>                           imsi_len-2, mi+2);</span><br><span>@@ -1247,6 +1248,7 @@</span><br><span>  * mi[131], which is wrong */</span><br><span> #pragma GCC diagnostic push</span><br><span> #pragma GCC diagnostic ignored "-Warray-bounds"</span><br><span style="color: hsl(120, 100%, 40%);">+       OSMO_ASSERT(imsi_len <= GSM48_MID_MAX_SIZE);</span><br><span>      msgb_tvlv_put(msg, BSSGP_IE_IMSI, imsi_len-2, mi+2);</span><br><span> #pragma GCC diagnostic pop</span><br><span>   /* DRX Parameters */</span><br><span>diff --git a/src/gb/gprs_bssgp_bss.c b/src/gb/gprs_bssgp_bss.c</span><br><span>index f06c403..5c9d11c 100644</span><br><span>--- a/src/gb/gprs_bssgp_bss.c</span><br><span>+++ b/src/gb/gprs_bssgp_bss.c</span><br><span>@@ -189,6 +189,7 @@</span><br><span>  * mi[131], which is wrong */</span><br><span> #pragma GCC diagnostic push</span><br><span> #pragma GCC diagnostic ignored "-Warray-bounds"</span><br><span style="color: hsl(120, 100%, 40%);">+      OSMO_ASSERT(imsi_len <= GSM48_MID_MAX_SIZE);</span><br><span>      /* strip the MI type and length values (2 bytes) */</span><br><span>  if (imsi_len > 2)</span><br><span>                 msgb_tvlv_put(msg, BSSGP_IE_IMSI, imsi_len-2, mi+2);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/16608">change 16608</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/16608"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I22a0c399c6c00eaf87277002096a82844c9e198e </div>
<div style="display:none"> Gerrit-Change-Number: 16608 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>