<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/16605">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">card_emu: Remove extraneous initialization of ch->pts.state<br><br>ch->pts.state is initialized every time we enter ISO_S_WAIT_TPDU<br>state, so there's no need to reset it at other locations. KISS.<br><br>Change-Id: I5ff8b2671c3c893cc5f6542d48b65487ae8c5be1<br>---<br>M firmware/libcommon/source/card_emu.c<br>1 file changed, 0 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c</span><br><span>index 5488fad..ced6b14 100644</span><br><span>--- a/firmware/libcommon/source/card_emu.c</span><br><span>+++ b/firmware/libcommon/source/card_emu.c</span><br><span>@@ -256,8 +256,6 @@</span><br><span> </span><br><span>     tc_etu_disable(ch->tc_chan);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     ch->tpdu.state = TPDU_S_WAIT_CLA;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>         /* release any buffers we may still own */</span><br><span>   if (ch->uart_tx_msg) {</span><br><span>            usb_buf_free(ch->uart_tx_msg);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/16605">change 16605</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/16605"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5ff8b2671c3c893cc5f6542d48b65487ae8c5be1 </div>
<div style="display:none"> Gerrit-Change-Number: 16605 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>