<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/16601">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">card_emu: Initialize PTSS state every time we start PTS<br><br>Let's shift the responsibility from the caller side to the calee side.<br><br>Change-Id: I39661ca93c87b2e2071765f69578eec5aaf90ce4<br>---<br>M firmware/libcommon/source/card_emu.c<br>1 file changed, 2 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c</span><br><span>index 63bf0d3..c3299de 100644</span><br><span>--- a/firmware/libcommon/source/card_emu.c</span><br><span>+++ b/firmware/libcommon/source/card_emu.c</span><br><span>@@ -240,7 +240,6 @@</span><br><span> </span><br><span>  tc_etu_disable(ch->tc_chan);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     ch->pts.state = PTS_S_WAIT_REQ_PTSS;</span><br><span>      ch->tpdu.state = TPDU_S_WAIT_CLA;</span><br><span> </span><br><span>     /* release any buffers we may still own */</span><br><span>@@ -534,8 +533,6 @@</span><br><span>             /* update waiting time (see ISO 7816-3 10.2) */</span><br><span>              ch->waiting_time = ch->wi * 960 * ch->fi;</span><br><span>           tc_etu_set_wtime(ch->tc_chan, ch->waiting_time);</span><br><span style="color: hsl(0, 100%, 40%);">-          /* reset PTS to initial state */</span><br><span style="color: hsl(0, 100%, 40%);">-                set_pts_state(ch, PTS_S_WAIT_REQ_PTSS);</span><br><span>              /* go to next state */</span><br><span>               card_set_state(ch, ISO_S_WAIT_TPDU);</span><br><span>                 return 0;</span><br><span>@@ -701,7 +698,6 @@</span><br><span>              emu_update_fidi(ch);</span><br><span>                 /* Wait for the next TPDU */</span><br><span>                 card_set_state(ch, ISO_S_WAIT_TPDU);</span><br><span style="color: hsl(0, 100%, 40%);">-            set_pts_state(ch, PTS_S_WAIT_REQ_PTSS);</span><br><span>              break;</span><br><span>       default:</span><br><span>             /* calculate the next state and set it */</span><br><span>@@ -979,6 +975,8 @@</span><br><span>      switch (ch->state) {</span><br><span>      case ISO_S_WAIT_TPDU:</span><br><span>                if (byte == 0xff) {</span><br><span style="color: hsl(120, 100%, 40%);">+                   /* reset PTS to initial state */</span><br><span style="color: hsl(120, 100%, 40%);">+                      set_pts_state(ch, PTS_S_WAIT_REQ_PTSS);</span><br><span>                      new_state = process_byte_pts(ch, byte);</span><br><span>                      ch->stats.pps++;</span><br><span>                  goto out_silent;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/16601">change 16601</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/16601"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I39661ca93c87b2e2071765f69578eec5aaf90ce4 </div>
<div style="display:none"> Gerrit-Change-Number: 16601 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>