<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/16573">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">more comments in host_communication.c.<br><br>Change-Id: I8b0124ec96b56b7c89e4c7033a11cc93c4fa2d26<br>---<br>M firmware/libcommon/source/host_communication.c<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libcommon/source/host_communication.c b/firmware/libcommon/source/host_communication.c</span><br><span>index d500aed..1e15ada 100644</span><br><span>--- a/firmware/libcommon/source/host_communication.c</span><br><span>+++ b/firmware/libcommon/source/host_communication.c</span><br><span>@@ -27,7 +27,7 @@</span><br><span>  * USBD Integration API</span><br><span>  ***********************************************************************/</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* call-back after (successful?) transfer of a buffer */</span><br><span style="color: hsl(120, 100%, 40%);">+/* call-back after (successful?) transfer of a write buffer on IN EP */</span><br><span> static void usb_write_cb(uint8_t *arg, uint8_t status, uint32_t transferred,</span><br><span>                         uint32_t remaining)</span><br><span> {</span><br><span>@@ -48,6 +48,7 @@</span><br><span>        usb_buf_free(msg);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* check if the spcified IN endpoint is idle and submit the next buffer from queue */</span><br><span> int usb_refill_to_host(uint8_t ep)</span><br><span> {</span><br><span>        struct usb_buffered_ep *bep = usb_get_buf_ep(ep);</span><br><span>@@ -99,7 +100,7 @@</span><br><span>       return 1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* call-back after (successful?) transfer of a buffer */</span><br><span style="color: hsl(120, 100%, 40%);">+/* call-back after (successful?) read transfer of a buffer on OUT EP */</span><br><span> static void usb_read_cb(uint8_t *arg, uint8_t status, uint32_t transferred,</span><br><span>                   uint32_t remaining)</span><br><span> {</span><br><span>@@ -120,6 +121,7 @@</span><br><span>       llist_add_tail_irqsafe(&msg->list, &bep->queue);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* refill the read queue for data received from host PC on OUT EP, if needed */</span><br><span> int usb_refill_from_host(uint8_t ep)</span><br><span> {</span><br><span>        struct usb_buffered_ep *bep = usb_get_buf_ep(ep);</span><br><span>@@ -158,6 +160,7 @@</span><br><span>      return 1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* drain any buffers from the queue of the endpoint and release their memory */</span><br><span> int usb_drain_queue(uint8_t ep)</span><br><span> {</span><br><span>  struct usb_buffered_ep *bep = usb_get_buf_ep(ep);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/16573">change 16573</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/16573"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8b0124ec96b56b7c89e4c7033a11cc93c4fa2d26 </div>
<div style="display:none"> Gerrit-Change-Number: 16573 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>