<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/16578">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cosmetic: board_qmod: Annotate #endif with comments<br><br>Change-Id: I2e2de6c65d791767637b9c43a1c0ff9cbeabf5e9<br>---<br>M firmware/libboard/qmod/source/board_qmod.c<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libboard/qmod/source/board_qmod.c b/firmware/libboard/qmod/source/board_qmod.c</span><br><span>index 900a3bc..b3979f4 100644</span><br><span>--- a/firmware/libboard/qmod/source/board_qmod.c</span><br><span>+++ b/firmware/libboard/qmod/source/board_qmod.c</span><br><span>@@ -194,7 +194,7 @@</span><br><span>     this is done to prevent accidental ERASE on noisy serial input since only one character can trigger the ERASE.</span><br><span>     */</span><br><span>  static bool allow_erase = false;</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#endif /* ALLOW_PEER_ERASE */</span><br><span> </span><br><span>    switch (ch) {</span><br><span>        case '?':</span><br><span>@@ -208,14 +208,14 @@</span><br><span> #if (ALLOW_PEER_ERASE > 0)</span><br><span>                   printf("\tE\tprogram EEPROM\n\r");</span><br><span>                         printf("\te\tErase EEPROM\n\r");</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#endif /* ALLOW_PEER_ERASE */</span><br><span>                      printf("\tO\tEnable PRTPWR_OVERRIDE\n\r");</span><br><span>                         printf("\to\tDisable PRTPWR_OVERRIDE\n\r");</span><br><span> #if (ALLOW_PEER_ERASE > 0)</span><br><span>                       printf("\tH\tRelease HUB RESET (high)\n\r");</span><br><span>                       printf("\th\tAssert HUB RESET (low)\n\r");</span><br><span>                         printf("\tw\tWrite single byte in EEPROM\n\r");</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#endif /* ALLOW_PEER_ERASE */</span><br><span>                       printf("\tr\tRead single byte from EEPROM\n\r");</span><br><span>           }</span><br><span>            printf("\tX\tRelease peer SAM3 from reset\n\r");</span><br><span>@@ -224,7 +224,7 @@</span><br><span>             printf("\tY\tRelease peer SAM3 ERASE signal\n\r");</span><br><span>                 printf("\ta\tAllow asserting peer SAM3 ERASE signal\n\r");</span><br><span>                 printf("\ty\tAssert peer SAM3 ERASE signal\n\r");</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#endif /* ALLOW_PEER_ERASE */</span><br><span>             printf("\tU\tProceed to USB Initialization\n\r");</span><br><span>          printf("\t1\tGenerate 1ms reset pulse on WWAN1\n\r");</span><br><span>              printf("\t2\tGenerate 1ms reset pulse on WWAN2\n\r");</span><br><span>@@ -275,7 +275,7 @@</span><br><span>                        printf("Please first allow setting SIMTRACExx_ERASE\n\r");</span><br><span>                 }</span><br><span>            break;</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#endif /* ALLOW_PEER_ERASE */</span><br><span>  case '1':</span><br><span>            printf("Resetting Modem 1 (of this SAM3)\n\r");</span><br><span>            wwan_perst_do_reset_pulse(0, 300);</span><br><span>@@ -303,7 +303,7 @@</span><br><span>     if ('a' != ch) {</span><br><span>             allow_erase = false;</span><br><span>         }</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#endif /* ALLOW_PEER_ERASE */</span><br><span> }</span><br><span> </span><br><span> void board_main_top(void)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/16578">change 16578</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/16578"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2e2de6c65d791767637b9c43a1c0ff9cbeabf5e9 </div>
<div style="display:none"> Gerrit-Change-Number: 16578 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>