<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/16585">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cardem: Fix memory leak on unsupported SIMTRACE_MSGT_DT_CEMU_CARDINSERT<br><br>Some boards like QMOD cannot simulate a virtual card insert signal<br>towards the modem (as the mPCIe connector doesn't have that signal).<br><br>In these situations, we were aborting processing of the related OUT<br>endpoint command and forgot to release the related memory.<br><br>Change-Id: I489097b7e332004e0f2beca0b22fa36d5d1d31b5<br>Related: OS#4251<br>---<br>M firmware/libcommon/source/mode_cardemu.c<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/85/16585/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libcommon/source/mode_cardemu.c b/firmware/libcommon/source/mode_cardemu.c</span><br><span>index 704e6ba..1669c2d 100644</span><br><span>--- a/firmware/libcommon/source/mode_cardemu.c</span><br><span>+++ b/firmware/libcommon/source/mode_cardemu.c</span><br><span>@@ -505,6 +505,7 @@</span><br><span>                if (!ci->pin_insert.pio) {</span><br><span>                        TRACE_INFO("%u: skipping unsupported card_insert to %s\r\n",</span><br><span>                                  ci->num, cardins->card_insert ? "INSERTED" : "REMOVED");</span><br><span style="color: hsl(120, 100%, 40%);">+                 usb_buf_free(msg);</span><br><span>                   break;</span><br><span>               }</span><br><span>            TRACE_INFO("%u: set card_insert to %s\r\n", ci->num,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/16585">change 16585</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/16585"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I489097b7e332004e0f2beca0b22fa36d5d1d31b5 </div>
<div style="display:none"> Gerrit-Change-Number: 16585 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>