<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16301">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  neels: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msc: expect only one Paging on GERAN<br><br>After discussion on this thread:<br>http://lists.osmocom.org/pipermail/openbsc/2019-November/013058.html<br><br>Do not expect repeated Paging on GERAN.<br><br>Pending clarification on 3G, still expect repeated Paging on Iu, though we are<br>not 100% certain that this is indeed required.<br><br>Fixes MSC_Tests.TC_lu_and_mt_sms_paging_repeated,<br>but not MSC_Tests_Iu.TC_iu_lu_and_mt_sms_paging_repeated<br><br>Change-Id: Ie914ea88f31ac158f4bd1700143bbe728dd05e0b<br>---<br>M msc/MSC_Tests.ttcn<br>1 file changed, 28 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index 6e482e2..a083606 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -1974,11 +1974,37 @@</span><br><span> </span><br><span>  f_vty_sms_send(hex2str(pars.imsi), "2342", "Hello SMS");</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      log("Expecting first Paging");</span><br><span>     /* MSC->BSC: expect PAGING from MSC */</span><br><span>    f_expect_paging();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  /* MSC->BSC: expect PAGING from MSC */</span><br><span style="color: hsl(0, 100%, 40%);">-       f_expect_paging();</span><br><span style="color: hsl(120, 100%, 40%);">+    if (g_pars.ran_is_geran) {</span><br><span style="color: hsl(120, 100%, 40%);">+            log("GERAN: expect no further Paging");</span><br><span style="color: hsl(120, 100%, 40%);">+     } else {</span><br><span style="color: hsl(120, 100%, 40%);">+              log("UTRAN: expect more Paging");</span><br><span style="color: hsl(120, 100%, 40%);">+   }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   timer T := 5.0;</span><br><span style="color: hsl(120, 100%, 40%);">+       T.start;</span><br><span style="color: hsl(120, 100%, 40%);">+      alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [g_pars.ran_is_geran] BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi)) {</span><br><span style="color: hsl(120, 100%, 40%);">+          setverdict(fail, "GERAN should not repeat Paging, but received a second Paging");</span><br><span style="color: hsl(120, 100%, 40%);">+           mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span style="color: hsl(120, 100%, 40%);">+     [not g_pars.ran_is_geran] BSSAP.receive(tr_RANAP_Paging(cs_domain, imsi_hex2oct(g_pars.imsi))) {</span><br><span style="color: hsl(120, 100%, 40%);">+              log("UTRAN: second Paging received, as expected");</span><br><span style="color: hsl(120, 100%, 40%);">+          setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span style="color: hsl(120, 100%, 40%);">+     [] T.timeout {</span><br><span style="color: hsl(120, 100%, 40%);">+                if (g_pars.ran_is_geran) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    log("GERAN: No further Paging received, as expected");</span><br><span style="color: hsl(120, 100%, 40%);">+                      setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+             } else {</span><br><span style="color: hsl(120, 100%, 40%);">+                      setverdict(fail, "UTRAN: Expected a second Paging");</span><br><span style="color: hsl(120, 100%, 40%);">+                        mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span> </span><br><span>        /* Establish DTAP / BSSAP / SCCP connection */</span><br><span>       f_establish_fully(EST_TYPE_PAG_RESP);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16301">change 16301</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16301"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie914ea88f31ac158f4bd1700143bbe728dd05e0b </div>
<div style="display:none"> Gerrit-Change-Number: 16301 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>