<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/16527">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu_l1_if: Check pag_req id_lv len fits buffer<br><br>Related: OS#4316<br>Change-Id: I803e1d2577a0d210e74feb5ca4c216375a5024ea<br>---<br>M src/pcu_l1_if.cpp<br>1 file changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp</span><br><span>index 5e22c5c..98e697d 100644</span><br><span>--- a/src/pcu_l1_if.cpp</span><br><span>+++ b/src/pcu_l1_if.cpp</span><br><span>@@ -19,6 +19,7 @@</span><br><span> </span><br><span> #include <stdio.h></span><br><span> #include <unistd.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <inttypes.h></span><br><span> #include <stdlib.h></span><br><span> #include <string.h></span><br><span> #include <errno.h></span><br><span>@@ -636,6 +637,13 @@</span><br><span>     LOGP(DL1IF, LOGL_DEBUG, "Paging request received: chan_needed=%d "</span><br><span>                 "length=%d\n", pag_req->chan_needed, pag_req->identity_lv[0]);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    /* check if identity does not fit: length > sizeof(lv) - 1 */</span><br><span style="color: hsl(120, 100%, 40%);">+      if (pag_req->identity_lv[0] >= sizeof(pag_req->identity_lv)) {</span><br><span style="color: hsl(120, 100%, 40%);">+               LOGP(DL1IF, LOGL_ERROR, "Paging identity too large (%" PRIu8 ")\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                       pag_req->identity_lv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+          return -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  return BTS::main_bts()->add_paging(pag_req->chan_needed,</span><br><span>                                               pag_req->identity_lv);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/16527">change 16527</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/16527"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I803e1d2577a0d210e74feb5ca4c216375a5024ea </div>
<div style="display:none"> Gerrit-Change-Number: 16527 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>